Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all additionalProperties constraint #132 #163

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Oct 15, 2024

Summary of the discussion

As suggested in #132 the flag additionalProperties: false gives warnings when validating datapackages.

Type of change (CHANGELOG.md)

Removed

  • Remove all additionalProperties is false (#163)

Workflow checklist

Automation

Closes #132

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added the type: bug 🐛 Something isn't working label Oct 15, 2024
@Ludee Ludee requested a review from jh-RLI October 15, 2024 13:34
@Ludee Ludee self-assigned this Oct 15, 2024
@Ludee Ludee marked this pull request as ready for review October 15, 2024 13:35
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good

@jh-RLI jh-RLI merged commit 00d63b9 into develop Oct 15, 2024
2 checks passed
@jh-RLI jh-RLI deleted the feature-132-additionalproperties branch October 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove "additionalProperties" constraint from the schema
2 participants