This repository was archived by the owner on Feb 18, 2025. It is now read-only.
feat: getXcnRate(), getXcnRateByBlockNumber #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xhiros
reviewed
Sep 25, 2023
| const axios = require('axios'); | ||
|
|
||
| const BASE_URL = 'https://api.onyx.org/api'; | ||
| const XCNContractAddress = '0x1961AD247B47F4f2242E55a0E5578C6cf01F8D12'; |
There was a problem hiding this comment.
Everything looks good to me.
The only thing is that the name of XCNContractAddress.
Actually that address is oXCN token, and the name - XCNContractAddress looks like the XCN token address.
There was a problem hiding this comment.
Yes, it's oXCN address. API responds with empty result when XCN address is used. getXcnRate(): tokenPrice is price of XCN token, not oXCN. getXcnRateByBlockNumber(): priceUSD is price of XCN token, not oXCN.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.