This repository was archived by the owner on Feb 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Update Liquidation #4
Open
dissimilllate
wants to merge
5
commits into
develop
Choose a base branch
from
chore/updateLiquidation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dissimilllate
commented
Jul 19, 2023
@@ -126,9 +131,32 @@ async function main() { | |||
console.log(`Borrower balance in XCN after liquidation: ${formatNumber(summary.after.borrowerXcnBalance / 1e18)}`); | |||
console.log(`Borrower balance locked for supply in XCN: ${formatNumber(summary.after.borrowerXcnLockedForSupply / 1e18)}`); | |||
|
|||
const liquidatorProfit = (summary.after.xcnLockedForSupply - amountToRepay) / 1e18; | |||
const protocolSeizeShareMantissa = await oXCN.protocolSeizeShareMantissa() / 1e16; | |||
const protocolSeizeShareCoefficient = await oXCN.protocolSeizeShareMantissa() / 1e18; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using additional variable to keep formulas simple, because:
protocolSeizeShareMantissa = await oXCN.protocolSeizeShareMantissa() / 1e16; // 2.8, whilst we need 0.028 for calculations
In javascript:
2.8 / 1e2 = 0.027999999999999997
dissimilllate
commented
Jul 19, 2023
|
||
// The percent, ranging from 0% to 100%, of a liquidatable account's borrow that can be repaid in a single liquidate transaction. | ||
// https://docs.onyx.org/comptroller/close-factor | ||
const closeFactorPercentage = (await Comptroller.callStatic.closeFactorMantissa() / 1e16) | ||
const liquidationIncentiveMantissa = (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e16); | ||
const liquidationIncentiveCoefficient = (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e18); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using additional variable to keep formulas simple, because:
liquidationIncentiveCoefficient = (await Comptroller.callStatic.liquidationIncentiveMantissa() / 1e16); // 110, whilst we need 1.1 for calculations
In javascript:
1.1 / 1e2 = 0.011000000000000001
Setland34
approved these changes
Oct 31, 2024
Setland34
approved these changes
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.