Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vinay Add "Created By-email" Component to Materials List Page #1230

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Vinay Add "Created By-email" Component to Materials List Page #1230

wants to merge 1 commit into from

Conversation

vinayv-456
Copy link
Contributor

@vinayv-456 vinayv-456 commented Feb 14, 2025 •
edited
Loading

…cord's

Description

Enhance the Materials List page;s update and puchase models by adding a column to display the email of the user who added each material. This will improve traceability and accountability, making it easier to identify the source of entries.

Related PRS (if any):

This Backend PR is related to the 1361 frontend PR.
…

Main changes explained:

  • update bmMaterialsController.js to include requestor email for updateRecord and purchaseRecord
    …

How to test:

  1. check into current branch vinay/add_created_email_materials_list
  2. do npm install and npm start to run this PR locally

@vinayv-456 vinayv-456 mentioned this pull request Feb 14, 2025
Open
Peter-Nie2003
Peter-Nie2003 approved these changes Feb 14, 2025
View reviewed changes
Copy link

@Peter-Nie2003 Peter-Nie2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code work as expected!

Srichand-Medagani
Srichand-Medagani approved these changes Feb 15, 2025
View reviewed changes
Copy link

@Srichand-Medagani Srichand-Medagani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left the comments on frontend PR.

niccccccccer
niccccccccer approved these changes Feb 23, 2025
View reviewed changes
Copy link

@niccccccccer niccccccccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks well. I see the changes are implemented on the frontend side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccccccccer niccccccccer niccccccccer approved these changes

@Srichand-Medagani Srichand-Medagani Srichand-Medagani approved these changes

@Peter-Nie2003 Peter-Nie2003 Peter-Nie2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinayv-456 @niccccccccer @Srichand-Medagani @Peter-Nie2003