add charon exit and restructure for clarity #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for obol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anadi2311
requested review from
st1p3-obol
and removed request for
slugmann321
anadi2311
requested review from
slugmann321
and removed request for
st1p3-obol
slugmann321
reviewed
Jan 23, 2025
slugmann321
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Step 3: Broadcast the full exit
In the text, we write a choice of "Fetch the full exit and broadcast instantaneously" or "Fetch the full exit and broadcast it later" but then the two tabs that are available don't relate to "now" vs "later" but rather "broadcast directly" or "fetch & broadcast". That choice hasn't been explained in the preceding text.
KaloyanTanev
approved these changes
Jan 23, 2025
fixing "threshold" language
minor typo fixes
slugmann321
approved these changes
Jan 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for charon exit
Details
Added charon exit all commands. Did some restructure to maintain parity in command and userflow same as launchpad