Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for anti affinity configuration in helm charts #1296

Conversation

NotAndD
Copy link
Contributor

@NotAndD NotAndD commented Mar 24, 2025

Description

Following what was done in pull/1180, there is an annotation that can be used to enforce leader-follower anti affinity using a mutating webhook. But it's not possible to use it from the provided Helm Charts.

I added the following:

  • Possibility to add the annotation on the RedisCluster resource by using redisCluster.enableMasterSlaveAntiAffinity
  • Possibility to disable the creation of cert-manager Issuer (which might be not required) in case someone wants to use an existing one for the Certificate
  • Possibility to create it as a ClusterIssuer, if desired. And also to use this kind of issuer in the certificate.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
    • There are no tests for the Helm Charts (it seems)
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

I left the default parameters in the values to configure the chart as before, so there should be no changes, unless parameters are personalized.

…reation optional to use cert-amanger

Signed-off-by: Andrea Dolfi <andrea.dolfi.e@thalesdigital.io>
@NotAndD NotAndD force-pushed the add-support-for-anti-affinity-configuration-in-helm-charts branch from d191b22 to 6717ed8 Compare March 24, 2025 14:46
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1e10066). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage        ?   34.37%           
=======================================
  Files           ?       55           
  Lines           ?     6063           
  Branches        ?        0           
=======================================
  Hits            ?     2084           
  Misses          ?     3797           
  Partials        ?      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotAndD NotAndD changed the title Add support for anti affinity configuration in helm charts feat: Add support for anti affinity configuration in helm charts Mar 25, 2025
Andrea Dolfi added 2 commits March 25, 2025 08:48
Signed-off-by: Andrea Dolfi <andrea.dolfi.e@thalesdigital.io>
Signed-off-by: Andrea Dolfi <andrea.dolfi.e@thalesdigital.io>
@NotAndD NotAndD force-pushed the add-support-for-anti-affinity-configuration-in-helm-charts branch from fc594ab to 846540d Compare March 25, 2025 07:48
@NotAndD
Copy link
Contributor Author

NotAndD commented Mar 25, 2025

Sorry, thought the readme files were updated manually, should have noticed the templetized readmes (internal facepalm)

Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit 317fc37 into OT-CONTAINER-KIT:main Mar 25, 2025
19 checks passed
@NotAndD NotAndD deleted the add-support-for-anti-affinity-configuration-in-helm-charts branch March 25, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants