Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohort covariates unit tests #204

Merged
merged 10 commits into from
Jun 28, 2023
Merged

Conversation

anthonysena
Copy link
Collaborator

Expand unit tests for #167

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #204 (d3dd418) into cohortCovariates (1e46b67) will increase coverage by 0.10%.
The diff coverage is 94.24%.

@@                 Coverage Diff                  @@
##           cohortCovariates     #204      +/-   ##
====================================================
+ Coverage             93.30%   93.40%   +0.10%     
====================================================
  Files                    15       16       +1     
  Lines                  1165     1304     +139     
====================================================
+ Hits                   1087     1218     +131     
- Misses                   78       86       +8     
Impacted Files Coverage Δ
R/FeatureExtraction.R 60.00% <ø> (ø)
R/HelperFunctions.R 88.88% <40.00%> (-6.12%) ⬇️
R/GetCovariatesFromOtherCohorts.R 96.26% <96.26%> (ø)

@anthonysena anthonysena merged commit 6aa0a4c into cohortCovariates Jun 28, 2023
@anthonysena anthonysena deleted the cohortCovariates-unit-tests branch June 28, 2023 02:33
anthonysena added a commit that referenced this pull request Jun 28, 2023
* Adding covariate builders based on other cohorts

* Fixing build

* Regenerating jar using maven

* Implementing runTestsOnEunomia switch for new tests

* Some fixes to cohort-based covariates

* Adding a vignette for cohort-based covariates.

* Update CreatingCovariatesBasedOnOtherCohorts.Rmd

* Throw warning if using pre-spec analysis ID for cohort-based covariate.

* Adding count type temporal covariates based on other cohorts

* Allowing cohordId to be vector in cohort-based covariate builder

* Update vignette

* Expand cohort covariates unit tests (#204)

---------

Co-authored-by: Schuemie <MSCHUEMI@its.jnj.com>
Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>
Co-authored-by: Anthony Sena <asena5@its.jnj.com>
Co-authored-by: Ger Inberg <ginberg@gmail.com>
Co-authored-by: Anthony Sena <anthonysena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant