optimized

OHDSI · Sep 30, 2024 · bfa73aa · bfa73aa
1 parent 1ee792f
commit bfa73aa
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/R/GetMappedSourceConcepts.R b/R/GetMappedSourceConcepts.R
@@ -44,7 +44,7 @@ getMappedSourceConcepts <-
     }
 
     tempTableName <- loadTempConceptTable(
-      conceptIds = conceptIds,
+      conceptIds = conceptIds |> unique() |> sort(),
       connection = connection,
       tempEmulationSchema = tempEmulationSchema
     )

diff --git a/R/GetMappedStandardConcepts.R b/R/GetMappedStandardConcepts.R
@@ -44,7 +44,7 @@ getMappedStandardConcepts <-
     }
 
     tempTableName <- loadTempConceptTable(
-      conceptIds = conceptIds,
+      conceptIds = conceptIds |> unique() |> sort(),
       tempEmulationSchema = tempEmulationSchema,
       connection = connection
     )

diff --git a/R/ResolveConceptSetExpression.R b/R/ResolveConceptSetExpression.R
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-#' Given a concept set expression, get the resolved concepts
+#' Given a concept set expression, get the resolved concept ids.
 #'
 #' @template Connection
 #'
@@ -26,7 +26,7 @@
 #' @template TempEmulationSchema
 #'
 #' @return
-#' Returns a tibble data frame.
+#' Returns a tibble data frame of distinct sorted concept ids.
 #'
 #' @export
 resolveConceptSetExpression <- function(conceptSetExpression,
@@ -49,8 +49,9 @@ resolveConceptSetExpression <- function(conceptSetExpression,
       snakeCaseToCamelCase = TRUE,
       tempEmulationSchema = tempEmulationSchema
     ) |>
+    dplyr::distinct() |> 
     dplyr::arrange(conceptId) |> 
-    dplyr::tibble()
+    dplyr::pull()
 
   return(resolvedConceptIds)
 }
diff --git a/man/resolveConceptSetExpression.Rd b/man/resolveConceptSetExpression.Rd