Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for InterSystems IRIS dialect #717

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Adding support for InterSystems IRIS dialect #717

wants to merge 11 commits into from

Conversation

bdeboe
Copy link

@bdeboe bdeboe commented Sep 30, 2024

This Pull Request adds DDL files generated for the new InterSystems IRIS dialect recently added to SqlRender per OHDSI/SqlRender@e5463e2, to address #716

@bdeboe bdeboe mentioned this pull request Sep 30, 2024
Closed
@bdeboe
Copy link
Author

bdeboe commented Oct 23, 2024

The additional unit tests (off by default per the testDatabases <- c("postgresql") in setup.R) rely on the following environment variables:

CDMDDLBASE_IRIS_URL
CDMDDLBASE_IRIS_USER
CDMDDLBASE_IRIS_PASSWORD
CDMDDLBASE_IRIS_CDM_SCHEMA

I can provide values for these to reach our test server through email to the repo admin if needed, though this whole thing is pending a PR for the OHDSI/DatabaseConnector repo.

@bdeboe
Copy link
Author

bdeboe commented Jan 31, 2025

OHDSI/DatabaseConnector#302 was just approved and is now part of DatabaseConnector 6.4. Hopefully that means this PR can now also proceed?

clairblacketer
clairblacketer reviewed Mar 6, 2025
View reviewed changes
tests/testthat/setup.R
server = Sys.getenv("CDMDDLBASE_ORACLE_SERVER"),
pathToDriver = jdbcDriverFolder
),
"iris" = createConnectionDetails(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdeboe. Can you confirm that there is an OHDSI iris testing environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairblacketer clairblacketer clairblacketer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdeboe @clairblacketer