Fix endless loop issue when Schema tag has no correct xmlns value. #3192
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanjohiSammy
requested review from
marabooy,
paulodero,
habbes,
xuzhg,
gathogojr,
Copilot and
ElizabethOkerio
There was a problem hiding this comment.
PR Overview
This PR addresses an endless loop issue encountered when the Schema tag has either an invalid or missing xmlns attribute, by adding reader.Skip() calls to properly advance past problematic elements.
- Fix endless loop by invoking reader.Skip() after reporting unexpected namespaces or elements.
- Add comprehensive unit tests to verify error reporting when encountering invalid or missing namespace attributes in both Schema and Edmx tags.
Reviewed Changes
| File | Description |
|---|---|
| test/UnitTests/Microsoft.OData.Edm.Tests/Csdl/CsdlReaderTests.cs | Introduces new test cases to validate error handling for invalid or missing xmlns values. |
| src/Microsoft.OData.Edm/Csdl/Parsing/Common/XmlDocumentParser.cs | Adds reader.Skip() calls following error reporting to prevent endless loops during XML parsing. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
gathogojr
reviewed
Mar 4, 2025
xuzhg
approved these changes
Mar 4, 2025
xuzhg
approved these changes
Mar 4, 2025
| @@ -148,6 +148,7 @@ internal void ParseDocumentElement() | |||
| else | |||
| { | |||
| this.ReportUnexpectedRootNamespace(this.reader.LocalName, this.DocumentNamespace, expectedNamespaces); | |||
| this.reader.Skip(); | |||
There was a problem hiding this comment.
Can we just tolerate to allow the missing and append it by default by use and only report the wrong namespace used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #3188.
Description
This PR addresses an issue where an endless loop occurs when the
Schematag does not havexmlnsattribute or correctxmlnsvalue. The fix involves addingreader.Skip()before the return statement to ensure the reader skips to the end tag of the current element.Adding
reader.Read()will move the reader to the next element and results to elements with opening and closing tags that do not match.Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.