[14.0][IMP] stock_warehouse_flow: Improve flow matching #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, applying a flow on a move would prevent trying to find a new flow for it, as it changes picking_type_id, which is the first criterion for flow matching. This commits backs up original picking_type_id so a new flow can be searched for, if move values are modified after a flow is applied.
sebalix
reviewed
Mar 5, 2025
| # Only pick_ship matches, because there's a constraint on the carrier | ||
| matching_flows = self.env["stock.warehouse.flow"]._search_for_move(move_ship) | ||
| self.assertEqual(matching_flows, flow_pick_ship) | ||
| # Drop the carrier from the procurement, only direct flow should match |
There was a problem hiding this comment.
Suggested change
| # Drop the carrier from the procurement, only direct flow should match | |
| # Drop the carrier from the procurement, only ship only flow should match |
as "direct" is used for shipping policy (confusing)
sebalix
reviewed
Mar 5, 2025
Comment on lines
+30
to
+31
| # Drop default_picking_type_id, no flow is found, because | ||
| # now flow has Delivery Orders POST as from_picking_type_id |
There was a problem hiding this comment.
Not sure to understand this comment. Current move operation type (which has been updated at the beginning) doesn't match any flows?
There was a problem hiding this comment.
You create the move with picking type A.
All flows have from_picking_type_id == A.
If you apply any of those flows to the move, picking_type_id is updated to to_picking_type_id (B).
The only reason why it was matching before is because we made a backup of A in default_picking_type_id.
Drop this backup, it doesn't match any flow anymore.
sebalix
reviewed
Mar 5, 2025
sebalix
changed the title
mmequignon
force-pushed
the
14.0-stock_warehouse_flow_allow_multiple_search
branch
from
aaa6b64 to
7a75420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide the possibility to update a flow on pickings when carrier is updated.
based on: