Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] shopfloor: checkout scan change lot - port of #712 #977

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

jbaudoux
Copy link
Contributor

sebalix and others added 3 commits January 30, 2025 10:19
When it comes to select a line, scanning the wrong lot will invite the
user to scan it again to change it on the relevant line only if there is
one sharing the same product.
@OCA-git-bot
Copy link
Contributor

Hi @simahawk, @sebalix, @guewen,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG (compared with v14 PR)

@@ -1749,6 +1826,7 @@ def _schema_stock_picking_details(self):
group_lines_by_location={"type": "boolean"},
show_oneline_package_content={"type": "boolean"},
need_confirm_pack_all={"type": "string"},
need_confirm_lot={"type": "integer"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v14 PR was adding nullable: True here, removed on purpose?

EDIT: ok you switched from None to False everywhere

Copy link
Contributor

@sebalix sebalix Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not remember why it was put as integer+nullable instead of boolean... like if there was a trap there.

EDIT: was done in this commit: b55b89a which hasn't been ported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explains the errors I was getting. I included that missing commit and reduced my mig commit to its minimum

@sebalix sebalix added this to the 16.0 milestone Jan 31, 2025
sebalix and others added 3 commits January 31, 2025 15:42
Adapt to v16
Changing lot requires the lot to exist on the location, you cannot create negative quant anymore
@jbaudoux
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-977-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d7e9d65 into OCA:16.0 Jan 31, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 65779fd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants