-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] shopfloor: checkout scan change lot - port of #712 #977
Conversation
When it comes to select a line, scanning the wrong lot will invite the user to scan it again to change it on the relevant line only if there is one sharing the same product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG (compared with v14 PR)
shopfloor/services/checkout.py
Outdated
@@ -1749,6 +1826,7 @@ def _schema_stock_picking_details(self): | |||
group_lines_by_location={"type": "boolean"}, | |||
show_oneline_package_content={"type": "boolean"}, | |||
need_confirm_pack_all={"type": "string"}, | |||
need_confirm_lot={"type": "integer"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v14 PR was adding nullable: True
here, removed on purpose?
EDIT: ok you switched from None to False everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not remember why it was put as integer+nullable
instead of boolean... like if there was a trap there.
EDIT: was done in this commit: b55b89a which hasn't been ported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explains the errors I was getting. I included that missing commit and reduced my mig commit to its minimum
Adapt to v16 Changing lot requires the lot to exist on the location, you cannot create negative quant anymore
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 65779fd. Thanks a lot for contributing to OCA. ❤️ |
Port of:
cc @sebalix