Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_release_channel_partner_delivery_window #753

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[16.0][ADD] stock_release_channel_partner_delivery_window #753

merged 1 commit into from
Nov 21, 2023

Conversation

nguyenminhchien
Copy link
Contributor

@nguyenminhchien nguyenminhchien commented Sep 19, 2023 •
edited
Loading

@nguyenminhchien nguyenminhchien changed the title [ADD] stock_release_channel_partner_delivery_window [16.0][ADD] stock_release_channel_partner_delivery_window Sep 19, 2023
@nguyenminhchien nguyenminhchien force-pushed the 16.0-add-stock_release_channel_partner_delivery_window branch from f0885fb to 634855f Compare September 19, 2023 09:48
@nguyenminhchien nguyenminhchien marked this pull request as ready for review September 19, 2023 10:44
cyrilmanuel
cyrilmanuel approved these changes Sep 21, 2023
View reviewed changes
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but LGTM

simahawk
simahawk requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the screenshot seems not relevant, right?

@nguyenminhchien nguyenminhchien force-pushed the 16.0-add-stock_release_channel_partner_delivery_window branch from 634855f to c0fa723 Compare October 9, 2023 03:27
@nguyenminhchien
Copy link
Contributor Author

the screenshot seems not relevant, right?

removed, thanks.

simahawk
simahawk reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just minor remarks

@nguyenminhchien nguyenminhchien force-pushed the 16.0-add-stock_release_channel_partner_delivery_window branch from c0fa723 to 78b0cdb Compare November 20, 2023 10:38
@nguyenminhchien nguyenminhchien force-pushed the 16.0-add-stock_release_channel_partner_delivery_window branch from 1c0eecc to 93ab520 Compare November 21, 2023 05:03
@nguyenminhchien nguyenminhchien force-pushed the 16.0-add-stock_release_channel_partner_delivery_window branch from 93ab520 to b325785 Compare November 21, 2023 05:16
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-753-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fdbe511 into OCA:16.0 Nov 21, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at feca63d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nguyenminhchien @simahawk @OCA-git-bot @jbaudoux @cyrilmanuel