Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] web_search_with_and #3115

Merged
merged 31 commits into from
Mar 11, 2025
Merged

[18.0][MIG] web_search_with_and #3115

merged 31 commits into from
Mar 11, 2025

Conversation

JasminSForgeFlow
Copy link
Contributor

Standard Migration

@ForgeFlow

Andrius Preimantas and others added 30 commits March 7, 2025 17:19
@JasminSForgeFlow
Squash of 8 commits
e254db2 
Add README.rst

Too short underline for module title in README.rst

Improving module meta information

Version 1.0

W391 blank line at end of file

Remove module description because README.rst is there

web_search_with_and: Latest OCA conventions
@Creamaster @JasminSForgeFlow
Migrate web_search_with_and from 8.0 to 10.0
56b8049
@OpenCode @JasminSForgeFlow
web_search_with_and: Migration to 11.0
671b951
@oca-travis @JasminSForgeFlow
Update web_search_with_and.pot
b1c5d6f
@ddufresne @JasminSForgeFlow
Port web_search_with_and to version 12.0
0dc5762
@oca-travis @JasminSForgeFlow
Update web_search_with_and.pot
a670283
@OCA-git-bot @JasminSForgeFlow
README.rst
bd68e84
@pedrocs-exo @JasminSForgeFlow
Added translation using Weblate (Portuguese)
800c343
@OCA-git-bot @JasminSForgeFlow
README.rst
22d8ffb
@OCA-git-bot @JasminSForgeFlow
README.rst
1cb0416
@claudiagn @JasminSForgeFlow
Added translation using Weblate (Spanish)
5389642
@sbejaoui @JasminSForgeFlow
- migration web_search_with_and
07f40c0
@oca-travis @JasminSForgeFlow
Update web_search_with_and.pot
e4b2b09
@OCA-git-bot @JasminSForgeFlow
README.rst
cbad8b7
@alessandro-fiorino @JasminSForgeFlow
Added translation using Weblate (Italian)
8173a0b
@pedroguirao @JasminSForgeFlow
web_search_with_and: black, isort, prettier
a1047e9
@pedroguirao @JasminSForgeFlow
web_search_with_and: Migration to 14.0
10d4229
@oca-travis @JasminSForgeFlow
Update web_search_with_and.pot
d9f8e19
@OCA-git-bot @JasminSForgeFlow
README.rst
10e0b09
@JasminSForgeFlow
web_search_with_and: Migration to 15.0
4efb052
@JasminSForgeFlow
Update web_search_with_and.pot
ac4f127
@OCA-git-bot @JasminSForgeFlow
README.rst
f352f9b
@Sandip-scs @JasminSForgeFlow
[16.0][MIG] web_search_with_and.
b285b06
@JasminSForgeFlow
[UPD] Update web_search_with_and.pot
a89b053
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
9cba5af
@weblate @JasminSForgeFlow
Update translation files
5610631 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_search_with_and
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_search_with_and/
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
80e670b
@JasminSForgeFlow
[IMP] web_search_with_and: black, isort, prettier
9bf04fa
@JasminSForgeFlow
[MIG] web_search_with_and: Migration to 17.0
e579e85
@JasminSForgeFlow
[IMP] web_search_with_and: black, isort, prettier
72a5d2f
@JasminSForgeFlow JasminSForgeFlow marked this pull request as ready for review March 7, 2025 12:25
JordiMForgeFlow
JordiMForgeFlow approved these changes Mar 7, 2025
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

AaronHForgeFlow
AaronHForgeFlow reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. It seems not to work. In runboat of v17:
image

But in this PR runboat I can't get the OR when pressing the shift button:

image

Am I doing it wrong?

@JasminSForgeFlow JasminSForgeFlow force-pushed the 18.0-mig-web_search_with_and branch from 11288ae to f488992 Compare March 10, 2025 03:52
@JasminSForgeFlow
Copy link
Contributor Author

Functional review. It seems not to work. In runboat of v17: image

But in this PR runboat I can't get the OR when pressing the shift button:

image

Am I doing it wrong?

When you search with shift pressed, it will apply AND condition, without shift press it will apply OR condition which is Odoo standard.

@AaronHForgeFlow
Copy link
Contributor

When you search with shift pressed, it will apply AND condition, without shift press it will apply OR condition which is Odoo standard.

Correct. I thought it was the other way around, sorry.

AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional 👍

@JordiBForgeFlow
Copy link
Member

@etobella can you merge this one?

etobella
etobella approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3115-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b627a41 into OCA:18.0 Mar 11, 2025
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8eae7a7. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-mig-web_search_with_and branch March 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@etobella etobella etobella approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.