-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] web_company_color: Migration to version 18.0 #3110
Conversation
d52af14
to
f5d0556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please squash administrative commits, thanks
/ocabot migration web_company_color |
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/zh_CN/
We need to disable the company unlinking test, as if not, when tested in integrated environments, it fails as there are records linked to the company, like the warehouse when `stock` module is installed.
If we change something with base.document.layout wizard, this will launch the colors computing even without changing the logo. This procedure will change the value of the colors if they were set by hand. This change forces the user to press a button to recompute the colors and avoid possible undesired changes. TT34902
Currently translated at 100.0% (10 of 10 strings) Translation: web-15.0/web-15.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_company_color/de/
See upstream commit: odoo/odoo@0bc24a7
Currently translated at 100.0% (10 of 10 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/de/
Currently translated at 100.0% (10 of 10 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/nl/
Currently translated at 100.0% (10 of 10 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/es/
Before it didn't work if just a color was set because it couldn't find "color_navbar_bg_hover". Moreover, in odoo enterprise the navbar background color only worked for the main app menu, now it works for both main app menu and the navbar of the apps.
Currently translated at 100.0% (16 of 16 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/es/
Currently translated at 100.0% (16 of 16 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/it/
…ing the assetbundle When trying to charge the assetbundle the theme-color("primary") function is not found what causes problems when trying to set the default values. With this changes the default value is the value set on https://github.com/odoo/odoo/blob/ad9f8fae717aae4cad5b3715c1f73ee906b64f8d/addons/web/static/src/scss/primary_variables.scss#L55 this change avoid the problems and the module works fine. Addapted too the class for required fields.
…olors Allow each company's colors to be visible when running in debug assets mode. Fix the menu colors so they don't look like hyperlinks.
Currently translated at 100.0% (17 of 17 strings) Translation: web-17.0/web-17.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_company_color/it/
This functionality allows changing the color of the icons in the systray menu based on the Navbar Text Color.
Currently translated at 100.0% (17 of 17 strings) Translation: web-17.0/web-17.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_company_color/es/
f5d0556
to
21ff50b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at f58fa17. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT54364
@carlos-lopez-tecnativa @CarlosRoca13 please review