[17.0][FIX] web_responsive: Fix blank screen on search (support menus w/o xmlid) #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might also affect the 18.0 version (#3037) |
|
Please rewrite the commit message (and the PR title) according guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message |
ryanc-me
force-pushed
the
17.0-web_responsive-blank-screen
branch
from
b8105dc to
18638cb
Compare
…mlid) If a menu item is created manually via the Odoo UI, then it (likely) won't have an xmlid. As a result, the `t-foreach` fails, resulting in the whole Odoo UI crashing (a blank white screen is shown). This code should use `id` as the `t-key` instead, as that is *always* available, even for menu items created manually.
ryanc-me
force-pushed
the
17.0-web_responsive-blank-screen
branch
from
18638cb to
a1b29f3
Compare
ryanc-me
changed the title
|
@pedrobaeza Apologies, fixed now. |
pedrobaeza
approved these changes
Feb 25, 2025
RajuPillainz
approved these changes
Feb 26, 2025
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 457b9ed. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a menu item is created manually via the Odoo UI, then it (likely) won't have an xmlid. This code should use
idas thet-keyinstead, as that is always available.Fixes #3104
Explanation: With asset debugging enabled, we get an error
Error: Got duplicate key in t-foreach, because multiple elements have a blank""xmlid, and so we hit a key conflict.