[17.0][MIG] hr_timesheet_task_required #640

MohamedOsman7 · 2024-02-26T15:43:42Z

No description provided.

FrancoMaxime

LGTM: code review

Currently translated at 100.0% (9 of 9 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/nl_NL/

Currently translated at 66.6% (6 of 9 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/fr/

Currently translated at 100.0% (12 of 12 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_required/fr/

Currently translated at 100.0% (10 of 10 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_required/it/

Currently translated at 100.0% (10 of 10 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_required/es/

MohamedOsman7 · 2024-02-27T13:36:11Z

I encountered a problem which i will describe step by step with screenshots:

In the settings, under the project app settings, i did not set the checkmark in the field (Require Tasks on Timesheets):

2024-02-27 14_07_43-Odoo - Settings und 3 weitere Seiten - Geschäftlich – Microsoft Edge

In the project app, i choosed the project "Research & Development" and opened his settings:

2024-02-27 14_08_23-Odoo - Projects und 3 weitere Seiten - Geschäftlich – Microsoft Edge

I also did not set the checkmark in the field (Require Tasks on Timesheets):

2024-02-27 14_09_28-Odoo - Research Development und 3 weitere Seiten - Geschäftlich – Microsoft E

In the timesheet app, when attempting to create a timesheet entry with the same project without choosing a task, i encountered an unexpected error:

2024-02-27 14_10_56-Odoo - My Timesheets und 3 weitere Seiten - Geschäftlich – Microsoft Edge

Apart from the fact that the error occurs at all, where it should not occur, the error message does not match the error specified in the code, which is:

(Note: This screenshot is from version 16.0)

2024-02-27 13_39_08-Odoo - My Timesheets und 7 weitere Seiten - Profil 2 – Microsoft Edge

I would assume that something has changed in the new odoo standard in this regard. But i did not find anything yet. Any ideas?

CRogos

Tested and working, but some code improvements possible.

CRogos · 2024-02-28T08:01:14Z

hr_timesheet_task_required/views/res_config_settings.xml

@@ -10,27 +10,15 @@ License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
        <field name="inherit_id" ref="hr_timesheet.res_config_settings_view_form" />
        <field name="arch" type="xml">
            <xpath
-                expr="//div[@data-key='project']//field[@name='module_hr_timesheet']/../../.."
+                expr="//app[@data-string='Project']//block[@name='project_time']"


expr="//block[@name='project_time']"

should be sufficient.

CRogos · 2024-02-28T08:09:10Z

hr_timesheet_task_required/views/project_project.xml

                <div
                    class="col-lg-6 o_setting_box"
                    id="timesheet_task_settings"
-                    attrs="{'invisible': [('allow_timesheets', '=', False)]}"
+                    invisible="allow_timesheets == False"
                >
                    <div class="o_setting_left_pane">
                        <field name="is_timesheet_task_required" class="oe_inline" />


I think the hole div block should be replaced by this:

<setting id="timesheet_task_settings" help="Set tasks on timesheet as a mandatory field" invisible="allow_timesheets == False"> <field name="is_timesheet_task_required"/> </setting>

CRogos · 2024-02-28T08:14:05Z

hr_timesheet_task_required/views/account_analytic_line.xml

-                <attribute
-                    name="attrs"
-                >{'required':[('is_task_required','=',True)]}</attribute>
+                <attribute name="required">is_task_required == True


<attribute name="required">is_task_required</attribute>
should be enough.

CRogos · 2024-02-28T08:14:25Z

hr_timesheet_task_required/views/account_analytic_line.xml

-                <attribute
-                    name="attrs"
-                >{'required':[('is_task_required','=',True)]}</attribute>
+                <attribute name="required">is_task_required == True


Same here. remove "== True"

CRogos · 2024-02-28T08:18:00Z

hr_timesheet_task_required/views/account_analytic_line.xml

@@ -14,9 +14,8 @@ License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
                <field name="is_task_required" invisible="1" />


invisible needs to be changed to
column_invisible="True"

dreispt · 2024-02-28T12:38:08Z

/ocabot migration hr_timesheet_task_required

OCA-git-bot · 2024-03-02T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt · 2024-03-02T16:07:02Z

/ocabot merge nobump

OCA-git-bot · 2024-03-02T16:07:11Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-640-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-02T16:11:38Z

Congratulations, your PR was merged at 191eb44. Thanks a lot for contributing to OCA. ❤️

MohamedOsman7 marked this pull request as ready for review February 26, 2024 15:52

adrienpeiffer and others added 3 commits February 27, 2024 09:01

[ADD] Add hr_timesheet_task_required module

603ba02

[UPD] fix website url in manifest

d777246

[10.0][MIG] hr_timesheet_task_required

3a5794b

MohamedOsman7 force-pushed the 17.0-mig-hr_timesheet_task_required branch from 6419179 to 162c93c Compare February 27, 2024 09:17

FrancoMaxime approved these changes Feb 27, 2024

View reviewed changes

MohamedOsman7 force-pushed the 17.0-mig-hr_timesheet_task_required branch from 162c93c to 9e9c436 Compare February 27, 2024 09:18

benwillig and others added 23 commits February 27, 2024 10:16

[11.0][MIG] hr_timesheet_task_required migration

35bef3e

[FIX] hr_timesheet_task_required: 'position' instead of 'poistion'

1d760d1

[MIG] hr_timesheet_task_required: Migration to 12.0

5de4f1e

[IMP] hr_timesheet_task_required: configurable

b09bdf9

[FIX] hr_timesheet_task_required: do not require task by default

79ceddb

[FIX] hr_timesheet_task_required: warning on hr_timesheet_task_required

48425e9

[FIX] hr_timesheet_task_required: don't rely on text()

c7c7904

Added translation using Weblate (Dutch)

b6cfab7

[IMP] hr_timesheet_task_required: note about multi-company setting

dba5b80

Added translation using Weblate (Dutch)

0d71032

Added translation using Weblate (German)

4634fdb

[IMP] hr_timesheet_task_required: black, isort

a5cff3a

[13.0][MIG] hr_timesheet_task_required

f95dc54

[UPD] Brainbean Apps => CorporateHub

f0351db

[14.0][MIG]hr_timesheet_task_required

b947b8a

Added translation using Weblate (French (France))

8c714d4

Translated using Weblate (Dutch)

713bc96

Currently translated at 100.0% (9 of 9 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/nl_NL/

Translated using Weblate (French)

7f516c5

Currently translated at 66.6% (6 of 9 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/fr/

Added translation using Weblate (Spanish)

2cf2d80

[IMP] hr_timesheet_task_required: black, isort, prettier

765e9f5

[15.0][MIG] hr_timesheet_task_required: Migration to 15.0

9d530f8

Translated using Weblate (French)

e79c223

Currently translated at 100.0% (12 of 12 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_required/fr/

Added translation using Weblate (Italian)

339af91

Christopher Rogos and others added 5 commits February 27, 2024 10:16

[15.0][MIG] hr_timesheet_task_required: Migration to 16.0

bf6aa7a

Translated using Weblate (Italian)

d3572d7

Currently translated at 100.0% (10 of 10 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_required/it/

Translated using Weblate (Spanish)

d166119

Currently translated at 100.0% (10 of 10 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_required Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_required/es/

Added translation using Weblate (Portuguese (Brazil))

b5e911f

[IMP] hr_timesheet_task_required: black, isort, prettier

66b4816

MohamedOsman7 force-pushed the 17.0-mig-hr_timesheet_task_required branch from 9e9c436 to 50a9c80 Compare February 27, 2024 10:18

MohamedOsman7 marked this pull request as draft February 27, 2024 11:43

MohamedOsman7 force-pushed the 17.0-mig-hr_timesheet_task_required branch 2 times, most recently from 86278a3 to 23c81c7 Compare February 27, 2024 15:32

MohamedOsman7 marked this pull request as ready for review February 27, 2024 15:36

CRogos suggested changes Feb 28, 2024

View reviewed changes

MohamedOsman7 mentioned this pull request Feb 28, 2024

Migration to version 17.0 #617

Open

14 tasks

[17.0][MIG] hr_timesheet_task_required

28dcd4f

MohamedOsman7 force-pushed the 17.0-mig-hr_timesheet_task_required branch from 23c81c7 to 28dcd4f Compare February 28, 2024 09:15

CRogos approved these changes Feb 28, 2024

View reviewed changes

OCA-git-bot added the approved label Feb 28, 2024

OCA-git-bot added this to the 17.0 milestone Feb 28, 2024

OCA-git-bot added the ready to merge label Mar 2, 2024

OCA-git-bot added the bot is merging ⏳ label Mar 2, 2024

OCA-git-bot merged commit 2c73a0f into OCA:17.0 Mar 2, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 2, 2024

CRogos deleted the 17.0-mig-hr_timesheet_task_required branch March 4, 2024 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] hr_timesheet_task_required #640

[17.0][MIG] hr_timesheet_task_required #640

MohamedOsman7 commented Feb 26, 2024

FrancoMaxime left a comment

MohamedOsman7 commented Feb 27, 2024 •

edited

Loading

CRogos left a comment

CRogos Feb 28, 2024

CRogos Feb 28, 2024 •

edited

Loading

CRogos Feb 28, 2024

CRogos Feb 28, 2024

CRogos Feb 28, 2024

dreispt commented Feb 28, 2024

OCA-git-bot commented Mar 2, 2024

dreispt commented Mar 2, 2024

OCA-git-bot commented Mar 2, 2024

OCA-git-bot commented Mar 2, 2024

		@@ -14,9 +14,8 @@ License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
		<field name="is_task_required" invisible="1" />

[17.0][MIG] hr_timesheet_task_required #640

[17.0][MIG] hr_timesheet_task_required #640

Conversation

MohamedOsman7 commented Feb 26, 2024

FrancoMaxime left a comment

Choose a reason for hiding this comment

MohamedOsman7 commented Feb 27, 2024 • edited Loading

CRogos left a comment

Choose a reason for hiding this comment

CRogos Feb 28, 2024

Choose a reason for hiding this comment

CRogos Feb 28, 2024 • edited Loading

Choose a reason for hiding this comment

CRogos Feb 28, 2024

Choose a reason for hiding this comment

CRogos Feb 28, 2024

Choose a reason for hiding this comment

CRogos Feb 28, 2024

Choose a reason for hiding this comment

dreispt commented Feb 28, 2024

OCA-git-bot commented Mar 2, 2024

dreispt commented Mar 2, 2024

OCA-git-bot commented Mar 2, 2024

OCA-git-bot commented Mar 2, 2024

MohamedOsman7 commented Feb 27, 2024 •

edited

Loading

CRogos Feb 28, 2024 •

edited

Loading