Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][ADD] server_action_mass_edit_onchange: extension to support playing onchange #985

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][ADD] server_action_mass_edit_onchange: extension to support playing onchange #985

wants to merge 1 commit into from

Conversation

trisdoan
Copy link

@trisdoan trisdoan commented Dec 25, 2024 •
edited
Loading

@trisdoan trisdoan mentioned this pull request Dec 25, 2024
Merged
StephaneMangin
StephaneMangin approved these changes Feb 7, 2025
View reviewed changes
Copy link

@StephaneMangin StephaneMangin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legalsylvain
Copy link
Contributor

Hi could you rebase ?

ivantodorovich
ivantodorovich approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

ivantodorovich
ivantodorovich suggested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you rebase?

It looks like the commits of #951 are also in this PR, and they shouldn't

@trisdoan trisdoan force-pushed the 18.0-add-server_action_mass_edit_onchange branch from 46b3a93 to c00439a Compare February 11, 2025 10:50
@trisdoan
Copy link
Author

Hello @ivantodorovich, it's rebased, thanks

@legalsylvain
Copy link
Contributor

I don't get the error of the CI ...

@StefanRijnhart
Copy link
Member

@legalsylvain CI fixed in #1025

@legalsylvain
Copy link
Contributor

Thanks @StefanRijnhart. @trisdoan : could you rebase again ?

@trisdoan trisdoan force-pushed the 18.0-add-server_action_mass_edit_onchange branch from c00439a to fdc788e Compare February 12, 2025 02:36
vvrossem
vvrossem approved these changes Feb 12, 2025
View reviewed changes
server_action_mass_edit_onchange/readme/USAGE.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this file be either removed or filled with the module usage?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks

@trisdoan trisdoan force-pushed the 18.0-add-server_action_mass_edit_onchange branch from fdc788e to 63bfba0 Compare February 13, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich requested changes

@StephaneMangin StephaneMangin StephaneMangin approved these changes

@vvrossem vvrossem vvrossem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trisdoan @legalsylvain @StefanRijnhart @ivantodorovich @StephaneMangin @vvrossem @OCA-git-bot