Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] base_tier_validation - wrong order of reviewer when click… #1034

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

DucTruongKomit
Copy link

Current Behavior
the sequence order of review on Request Validation button be always reverted.

For example:
from Tier Definition, creating
On Purchase Request, User A will be set as sequence 1 (this person review 1st).
On Purchase Request, User B will be set as sequence 2 (this person review 2nd).

After clicking Request Validation button, User B always be asked to reviewed 1st.

Expected Behavior
Reviewing should be following the order of sequence.

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DucTruongKomit

This makes sense and it is an issue that needed to be addresed. However, to be able to merge this, you will need to provide migration scripts that reverts all the sequences in existing tier definitions to not change behavior in existing installations. Could you do that?

Thanks for contributing!

@DucTruongKomit
Copy link
Author

Hi @DucTruongKomit

This makes sense and it is an issue that needed to be addresed. However, to be able to merge this, you will need to provide migration scripts that reverts all the sequences in existing tier definitions to not change behavior in existing installations. Could you do that?

Thanks for contributing!

I will try to arrange time and work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants