Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] sale_order_note_template #3607

Open
wants to merge 12 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] sale_order_note_template #3607

wants to merge 12 commits into from

Conversation

IsabelAForgeFlow
Copy link

Migration to 18.0

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Mar 3, 2025
Closed
@IsabelAForgeFlow IsabelAForgeFlow force-pushed the 18.0-mig-sale_order_note_template branch 2 times, most recently from deb996b to 8aaeecd Compare March 3, 2025 13:39
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional + code 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebalix
Copy link
Contributor

sebalix commented Mar 10, 2025

/ocabot migration sale_order_note_template

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 10, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 10, 2025
Open
67 tasks
sebalix
sebalix reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the last commit from #3605 I guess

@IsabelAForgeFlow IsabelAForgeFlow force-pushed the 18.0-mig-sale_order_note_template branch from 8aaeecd to 310c3bf Compare March 24, 2025 12:30
@IsabelAForgeFlow IsabelAForgeFlow force-pushed the 18.0-mig-sale_order_note_template branch from 310c3bf to 9899a52 Compare March 24, 2025 13:50
@IsabelAForgeFlow
Copy link
Author

Missing the last commit from #3605 I guess

Done!

@dreispt
Copy link
Member

dreispt commented Mar 30, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3607-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 30, 2025
@OCA-git-bot
Merge PR #3607 into 18.0
339c1af 
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix left review comments

@dreispt dreispt dreispt approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved bot is merging ⏳ migration ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
9 participants
@IsabelAForgeFlow @OCA-git-bot @sebalix @dreispt @AaronHForgeFlow @MiquelRForgeFlow @petrus-v @oca-travis @aktiv-heli-kantawala