[18.0][MIG] report_qweb_pdf_cover #985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-16.0/reporting-engine-16.0-report_qweb_pdf_cover Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_qweb_pdf_cover/
Currently translated at 100.0% (21 of 21 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_qweb_pdf_cover Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_qweb_pdf_cover/it/
JasminSForgeFlow
force-pushed
the
18.0-mig-report_qweb_pdf_cover
branch
from
5840d84 to
6bad2c0
Compare
AaronHForgeFlow
approved these changes
Mar 5, 2025
| def pdf_check_pages(self, num_pages, front=True): | ||
| if num_pages < 1: | ||
| if front: | ||
| logger.error(_("Your front cover PDF does not contain any pages.")) |
There was a problem hiding this comment.
Suggested change
| logger.error(_("Your front cover PDF does not contain any pages.")) | |
| logger.error(self.env._("Your front cover PDF does not contain any pages.")) |
This is better performance. Can you please replace it in all '_' occurrences?
There was a problem hiding this comment.
Updated, Thanks
JasminSForgeFlow
force-pushed
the
18.0-mig-report_qweb_pdf_cover
branch
from
6bad2c0 to
4175e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard Migration
@ForgeFlow