Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add _get_pdf_watermark function to be able to inherit and select a pdf from another model. #950

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

hugomartineznetkia
Copy link
Contributor

This is an improvement for inheriting the module to be able to use watermarks from other models.

@mariancuadranetkia
Copy link

LGTM

@hugomartineznetkia
Copy link
Contributor Author

@HviorForgeFlow Hi! Could you review this PR?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Nov 27, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-950-by-hbrunn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4b55517. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 115bbb0 into OCA:16.0 Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants