[15.0][MIG] sql_export_mail: Migration to 15.0 #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the right to read crons.
…ine 16.0 branch - Update views, regarding changes in sql_export module - Add prepare function for cron vals
Refactore to use the new properties field
…to access to sql export
BT-ssteiner
force-pushed
the
15.0-mig-sql_export_mail
branch
from
e28e00b to
0cf07fe
Compare
|
@florian-dacosta could you review ? |
florian-dacosta
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM code review (no test)
It would be nice to forward port the tests to v16 so it is not lost during migration to v17 or v18
Would you mind doing a PR for this @BT-ssteiner ?
|
Hello @florian-dacosta |
|
Hello @legalsylvain |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c95ad89. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.