[16.0][REF] purchase_triple_discount: Consolidate discount in std field #2599
Conversation
Until now, the triple discount feature did use the standard Odoo field as the first discount field, adding only extra fields for the second and the third discount. This implied we had to override any function using discount to consider the other discounts properly. By adding an extra field discount1 to store the first discount, it allows to redefine the standard discount field to a computed field that will consolidate the triple discount from the other fields, and avoid the need to redefine anything relying on the discount field as it will already consider the triple discounts.
pedrobaeza
force-pushed
the
16.0-ref-purchase_triple_discount
branch
from
98c7e43 to
c679e18
Compare
Having conversions with currency rate, leads to a situation where what we want to test is correct, but with a rounding error, so let's use assertAlmostEqual to compensate it.
|
As suspected, both sets of changes are needed, so let's merge this for fixing the CI that is blocking other PRs. @legalsylvain please check later if you see any problem due to your initial reluctance. I have put a TODO to move the mixin to the upper module. /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1757121. Thanks a lot for contributing to OCA. ❤️ |
Do you talk about mixin refactoring ? Thanks for your work. |
Continuation of #2317 and following OCA/account-invoicing#1840
Try to fix the current red CI state.
Until now, the triple discount feature did use the standard Odoo field as the first discount field, adding only extra fields for the second and the third discount. This implied we had to override any function using discount to consider the other discounts properly.
By adding an extra field discount1 to store the first discount, it allows to redefine the standard discount field to a computed field that will consolidate the triple discount from the other fields, and avoid the need to redefine anything relying on the discount field as it will already consider the triple discounts.
@Tecnativa