[16.0][FIX] purchase_allowed_product: cannot find the vendor's products. #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaraldPanten
approved these changes
Apr 20, 2023
|
This use case was not checked properly before merging. This adaptation is needed so that the products are correctly filtered according to their supplier. On the other hand, a forward port of another commit has been done, as we promised a few weeks ago in #1797 Do you mind fast tracking this? THX! |
luis-ron
approved these changes
Apr 20, 2023
|
/ocabot merge major |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at da6c7f9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FP] PR #1797 to find products by the seller's reference.
[FIX] When a quote request is created and the option ''Use only allowed products'' is checked, the supplier's products do not appear in the dropdown when trying to add a new product.
This is because the "name" field of the product.supplierinfo module in v15 is renamed to "partner_id" in v16.
To reproduce the error:.
You can see that no product appears.