Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] purchase_allowed_product: cannot find the vendor's products. #1850

Merged

Conversation

angelgarciadelachica
Copy link

[FP] PR #1797 to find products by the seller's reference.

[FIX] When a quote request is created and the option ''Use only allowed products'' is checked, the supplier's products do not appear in the dropdown when trying to add a new product.
This is because the "name" field of the product.supplierinfo module in v15 is renamed to "partner_id" in v16.

To reproduce the error:.

  1. Go to the Purchasing module -> Configuration -> Vendor price List
  2. Create a new one with a product and a Vendor.
  3. Create a quote request.
  4. Fill in the Vendor field with the partner from the 'Vendor price List' we have just created.
  5. Check 'Use only allowed products'.
  6. Add a product

You can see that no product appears.

@angelgarciadelachica
Copy link
Author

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runboat. LGTM 👍

@HaraldPanten
Copy link
Contributor

HaraldPanten commented Apr 20, 2023

@pedrobaeza

This use case was not checked properly before merging.

This adaptation is needed so that the products are correctly filtered according to their supplier. name needs to be changed to partner_id.

On the other hand, a forward port of another commit has been done, as we promised a few weeks ago in #1797

Do you mind fast tracking this?

THX!

Copy link
Contributor

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. LGTM 👍🏻

Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1850-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 587d0cd into OCA:16.0 Apr 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at da6c7f9. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 16.0-fix-purchase_allowed_product branch April 21, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants