-
-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] purchase_allowed_product: cannot find the vendor's products. #1850
[16.0][FIX] purchase_allowed_product: cannot find the vendor's products. #1850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in runboat. LGTM 👍
This use case was not checked properly before merging. This adaptation is needed so that the products are correctly filtered according to their supplier. On the other hand, a forward port of another commit has been done, as we promised a few weeks ago in #1797 Do you mind fast tracking this? THX! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review. LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
/ocabot merge major |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at da6c7f9. Thanks a lot for contributing to OCA. ❤️ |
[FP] PR #1797 to find products by the seller's reference.
[FIX] When a quote request is created and the option ''Use only allowed products'' is checked, the supplier's products do not appear in the dropdown when trying to add a new product.
This is because the "name" field of the product.supplierinfo module in v15 is renamed to "partner_id" in v16.
To reproduce the error:.
You can see that no product appears.