Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #301

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update README.rst #301

wants to merge 4 commits into from

Conversation

gdgellatly
Copy link
Contributor

Add link to API
Add license badge
Format a little

Add link to API
Add license badge
Format a little
README.rst Outdated
Comment on lines 17 to 19
.. image:: https://img.shields.io/badge/License-AGPL%20v3-blue.svg
:target: https://www.gnu.org/licenses/agpl-3.0
:alt: License: AGPL v3
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. image:: https://img.shields.io/badge/License-AGPL%20v3-blue.svg
:target: https://www.gnu.org/licenses/agpl-3.0
:alt: License: AGPL v3
.. image:: https://img.shields.io/badge/license-AGPL--3-blue.png
:target: https://www.gnu.org/licenses/agpl-3.0
:alt: License: AGPL-3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I literally cut and paste that from a recommended gist - no problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should revert the image, that png is dog ugly compared to the nice clean svg. Is there any reason we want png specifically?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, as you wish. Just FYI svg files are not rendered in apps, thus I always put .png in readme files by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough reason for me, although the other images are svg's, I'll leave it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look the date of such change... I think this must be re-evaluated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in any case, this is not an app.

Should I maybe convert to Markdown too? RST was a bit funky to edit remembering the slight syntax differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is not an app. Let's put svg then!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we need to review the criteria for the rest, as Odoo has evolved. First of all, we nee to know where the incompatibility was.

Per Review

Co-authored-by: Miquel Raïch <miquel.raich@forgeflow.com>
@legalsylvain
Copy link
Contributor

legalsylvain commented May 16, 2023

@gdgellatly : could you rebase and fix conflict ?
Also the URL changed it is now https://oca.github.io/openupgradelib

@gdgellatly
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@gdgellatly The rebase process failed, because command git push --force odoonz tmp-pr-301:doc-link3 failed with output:

remote: Permission to odoonz/openupgradelib.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/odoonz/openupgradelib/': The requested URL returned error: 403

@MiquelRForgeFlow
Copy link
Contributor

@gdgellatly Could you give one last push to this PR? needs rebase (to solve conflicts) and squash commits...

@gdgellatly
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@gdgellatly The rebase process failed, because command git rebase origin/master failed with output:

Rebasing (1/2)
Auto-merging README.rst
CONFLICT (content): Merge conflict in README.rst
error: could not apply ebab638... Update README.rst
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply ebab638... Update README.rst


pip/pip3 install --ignore-installed git+https://github.com/OCA/openupgradelib.git@master
``pip install --ignore-installed git+https://github.com/OCA/openupgradelib.git@master``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the release to Pypi process is automated, the library is released regularly and there is no need to install from Github anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol ffs, try and do something little 3 years ago. Will fix Wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants