Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] maintenance_equipment_category_hierarchy: Migration to 17.0 #459

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from

Conversation

BhaveshHeliconia
Copy link

No description provided.

etobella and others added 14 commits January 29, 2025 16:59
Currently translated at 100.0% (9 of 9 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_equipment_category_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_equipment_category_hierarchy/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_equipment_category_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_equipment_category_hierarchy/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_equipment_category_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_equipment_category_hierarchy/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_category_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_category_hierarchy/
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 29, 2025
20 tasks
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @HeliconiaSolutions , thanks for your contribution!!

See comment, and also:

  • Could you add some demo data? This addon has such lack, and this is a good moment to solve this.
  • Testing in runboat, even without any new category created, when trying to group equipments by category, an error is raised. Not checked if the same error raises e.g. in v16. Could you check?
Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1787, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1815, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 2019, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 221, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 757, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 24, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 20, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 464, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 435, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/addons/web/models/models.py", line 239, in web_read_group
    groups = self._web_read_group(domain, fields, groupby, limit, offset, orderby, lazy)
  File "/opt/odoo/addons/web/models/models.py", line 265, in _web_read_group
    groups = self.read_group(domain, fields, groupby, offset=offset, limit=limit,
  File "/opt/odoo/odoo/models.py", line 2760, in read_group
    rows = self._read_group(domain, annoted_groupby.values(), annoted_aggregates.values(), offset=offset, limit=limit, order=orderby)
  File "/opt/odoo/odoo/models.py", line 1911, in _read_group
    sql_order, sql_extra_groupby, fnames_used = self._read_group_orderby(order, groupby_terms, query)
  File "/opt/odoo/odoo/models.py", line 2123, in _read_group_orderby
    sql_order_str = self.env.cr.mogrify(sql_order).decode()
  File "/opt/odoo/odoo/sql_db.py", line 316, in mogrify
    return self._obj.mogrify(query, params)
psycopg2.ProgrammingError: can't execute an empty query

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
    RPCError@http://oca-maintenance-17-0-pr459-71ccbe3e138c.runboat.odoo-community.org/web/assets/a43706a/web.assets_web.min.js:2925:319
    makeErrorFromResponse@http://oca-maintenance-17-0-pr459-71ccbe3e138c.runboat.odoo-community.org/web/assets/a43706a/web.assets_web.min.js:2928:163
    jsonrpc/promise</<@http://oca-maintenance-17-0-pr459-71ccbe3e138c.runboat.odoo-community.org/web/assets/a43706a/web.assets_web.min.js:2932:34

Comment on lines +5 to +6
- [Heliconia Solutions Pvt. Ltd.](<https://www.heliconia.io>)
- Bhavesh Heliconia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For basic migration adding yourself to contributors shouldn't be accepted, unless a new feature is provided IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants