Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] maintenance_equipment_meter #378

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

etobella
Copy link
Member

This module allows us to integrate a meter (Odometer, printed pages counter...) on equipments. Data can be fulfilled in equipments directly or in requests.

Approach is similar to fleet odometer, but for equipments

Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for this new module.

Comment on lines 70 to 79
<!--
<record model="ir.actions.act_window" id="maintenance_equipment_meter_act_window">
<field name="name">Maintenance Equipment Meter</field>
<field name="res_model">maintenance.equipment.meter</field>
<field name="view_mode">tree,form</field>
<field name="domain">[]</field>
<field name="context">{}</field>
</record>

<record model="ir.ui.menu" id="maintenance_equipment_meter_menu">
<field name="name">Maintenance Equipment Meter</field>
<field name="parent_id" ref="xmlid of parent menu"/>
<field name="action" ref="maintenance_equipment_meter_act_window"/>
<field name="sequence" eval="16"/>
</record>
Copy link
Member

@mamcode mamcode Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the intention of this commented code was to have a main menu to access all the meter records of all the equipments from a main menu. It would be nice if we can have this.
By the way, in this action I would group the records by equipment.

@etobella
Copy link
Member Author

etobella commented Apr 7, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-378-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2776766 into OCA:14.0 Apr 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c24b12. Thanks a lot for contributing to OCA. ❤️

@etobella etobella deleted the 14.0-meter branch April 29, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants