[16.0] [MIG] maintenance_plan #339

alexeirivera87 · 2023-06-14T17:50:06Z

No description provided.

etobella · 2023-06-14T17:59:15Z

maintenance_plan/tests/test_maintenance_plan.py

+        rendering, qweb_type = self.report_obj._render_qweb_text(
+            "base_maintenance.report_maintenance_request", generated_request.ids
+        )
+        self.assertFalse(rendering.decode("utf-8").find("TEST-INSTRUCTIONS") == -1)


REGEX was not working?

aleuffre

Overall looks good and seems to work, unsure about the reason for the few changes that were made compared to v15

aleuffre · 2023-06-17T19:46:54Z

maintenance_plan/views/maintenance_equipment_views.xml

+            <xpath expr="//group[@name='maintenance']/.." position="after">
+                <field
+                    name="maintenance_plan_ids"
+                    nolabel="1"
+                    context="{'default_equipment_id': active_id, 'hide_equipment_id': 1}"
+                >
+                    <tree>
+                        <field name="maintenance_kind_id" string="Kind" />
+                        <field name="maintenance_team_id" string="Team" />
+                        <field name="name" />
+                        <field name="start_maintenance_date" string="Start Date" />
+                        <field name="interval" />
+                        <field name="interval_step" />
+                        <field name="duration" />
+                        <field name="next_maintenance_date" />
+                        <field
+                            name="maintenance_plan_horizon"
+                            string="P. Horizon period"
+                        />
+                        <field name="planning_step" string="P. Horizon step" />
+                    </tree>
+                </field>
+            </xpath>


Not sure why the change from

<xpath expr="//group[@name='maintenance']/" position="after">

<xpath expr="//group[@name='maintenance']/.." position="after">

at the very least I would add a <group string="Maintenance Plans"> around the whole thing, or alternatively remove the nolabel option

aleuffre · 2023-06-17T19:51:28Z

Also there was an existing proposed migration #324 , make sure to check if someone has done the work already, or explicitly point out that you're superseeding the previous PR, please!

mamcode · 2023-07-01T22:07:04Z

Also there was an existing proposed migration #324 , make sure to check if someone has done the work already, or explicitly point out that you're superseeding the previous PR, please!

There is also another duplicated PR that proposes to migrate this module to v16. #265

mcassuto · 2023-07-05T01:34:01Z

@aleuffre @alexeirivera87 @mamcode
Hi guys since there is 3 PR in total, what should we do now ?

aleuffre · 2023-07-05T08:47:00Z

Leave a review on all of them, or the one you think is closest to being merged, both in terms of code and in terms of the author being more active.

In terms of code I think this one is closest to being done, there are just a few changes to be made.

Happy to open a 4th PR myself, since I'd like to have this merged ASAP 🤣

mcassuto · 2023-07-05T10:37:10Z

Ok let me check if it has been tested ok, I guess it is alreay done on production.

alexeirivera87 · 2023-07-05T13:17:08Z

Hello @mcassuto @aleuffre @mamcode

Yes, I did check the existing PR before submitting this one:

About #324 , on this migration the only thing the author did was to change the module version (and even this is not correct), and to remove a function that was failing in the tests.

About #265 , here the only thing that was done was to change the version of the module.

Regards

aleuffre · 2023-07-05T13:20:19Z

Hello @mcassuto @aleuffre @mamcode

Yes, I did check the existing PR before submitting this one:

About #324 , on this migration the only thing the author did was to change the module version (and even this is not correct), and to remove a function that was failing in the tests.

About #265 , here the only thing that was done was to change the version of the module.

Regards

In that case, we usually write superseds #number of the MR in the description, so we can keep track of such things. Thank you 🙏

etobella · 2023-07-06T11:08:41Z

Visually it works for me. Why did you remove the Regex on the test?

aleuffre · 2023-07-12T14:25:07Z

@alexeirivera87 if you could please address the changes that were requested, they're minor things and I think this is pretty close to getting merged.

if you don't have time, I'd like to pick it up myself (I'd preserve ownership of your commits) since I need this module merged as well.

Thank you for your contributions!

etobella · 2023-09-06T14:08:41Z

@alexeirivera87 can you check the issue with the REGEX?

alexeirivera87 · 2024-01-30T16:32:21Z

Hello @aleuffre @etobella

I reverted the changes in unit tests, so assertRegex is used as before.

Now I have to check why the test failed in method test_next_maintenance_date_02

Regards

etobella · 2024-01-30T16:38:16Z

But the test seems unrelated to the regex. Can you check it¿

alexeirivera87 · 2024-02-01T13:03:57Z

@etobella All tests passed.

Yes, the is related to dates. Some are failing when current date is January 30th or 31st.

regards

etobella · 2024-02-01T14:17:28Z

Wow!!! I see... that might happend every 4 years 😆

One option would be to use freezetime in order to avoid this. Can you try?

victoralmau · 2024-02-01T15:10:56Z

Hi, sorry for being late.
Added freeze_time in the tests in v15 #371 but I see there are v15 changes missing in the commit history, can you add it?

The problem with the last days of the month is that the last day of the following month is not used (in those that are generated).

… equipment maintenance team is not filled [ADD] icon.png

[UPD] Update maintenance_plan.pot

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/ [UPD] README.rst

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-15.0/maintenance-15.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_plan/

…equipments defined with a domain

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-15.0/maintenance-15.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_plan/

Currently translated at 100.0% (118 of 118 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_plan/it/

alexeirivera87 · 2024-02-01T18:06:40Z

@victoralmau @etobella

It should be ok now.

regards

victoralmau

Code review OK

etobella · 2024-02-02T07:24:44Z

/ocabot merge nobump

OCA-git-bot · 2024-02-02T07:24:57Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-339-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2024-02-02T07:30:45Z

Congratulations, your PR was merged at 4f5193f. Thanks a lot for contributing to OCA. ❤️

etobella · 2024-03-11T22:33:22Z

/ocabot migraion maintenance_plan

OCA-git-bot · 2024-03-11T22:33:24Z

Hi @etobella. Your command failed:

Invalid command: migraion.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

etobella · 2024-03-11T22:33:47Z

/ocabot migration maintenance_plan

etobella reviewed Jun 14, 2023

View reviewed changes

alexeirivera87 force-pushed the 16.0-mig-maintenance_plan branch from e84762b to 89a858f Compare June 14, 2023 18:34

aleuffre reviewed Jun 17, 2023

View reviewed changes

aleuffre mentioned this pull request Jun 17, 2023

[16.0][MIG] maintenance_plan #324

Closed

alexeirivera87 force-pushed the 16.0-mig-maintenance_plan branch 2 times, most recently from e4b880d to bb3321f Compare January 30, 2024 15:11

alexeirivera87 force-pushed the 16.0-mig-maintenance_plan branch from bb3321f to 23e4e60 Compare February 1, 2024 12:55

grindtildeath and others added 8 commits February 1, 2024 12:11

[ADD] maintenance_plan module (OCA#2)

cc84b0e

[FIX] maintenance_plan: README try me on runbot link

173e34f

[MIG] maintenance_plan: Migration to 11.0

51dfdc6

[FIX] maintenance_plan: prevent preventive request cron crashing when…

07c93c6

… equipment maintenance team is not filled [ADD] icon.png

[MIG] maintenance_plan: Migration to 12.0

74983fc

[UPD] Update maintenance_plan.pot

Added translation using Weblate (Spanish)

97322a3

Translated using Weblate (Spanish)

0b4f1bf

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/ [UPD] README.rst

Added translation using Weblate (Chinese (Simplified))

278086e

weblate and others added 13 commits February 1, 2024 12:11

Update translation files

d6af8ee

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-15.0/maintenance-15.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_plan/

[IMP] maintenance_plan: Add freeze_time to prevent errors in tests

79d9bbc

[BOT] post-merge updates

8e144d8

[IMP] maintenance_plan: Allow to generate generic plans for multiple …

e5a64bc

…equipments defined with a domain

[FIX] maintenance_plan: The search must work with newIds

c58ffc3

[IMP] maintenance_plan: Add Team filter

973264a

[FIX] maintenance_plan: adapt tests

fba270b

[UPD] Update maintenance_plan.pot

791e46a

[BOT] post-merge updates

3bbff1c

Update translation files

da16664

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-15.0/maintenance-15.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_plan/

Translated using Weblate (Italian)

f5e28b8

Currently translated at 100.0% (118 of 118 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_plan/it/

[IMP] maintenance_plan: pre-commit stuff

8787b38

[MIG] maintenance_plan: Migration to 16.0

106a09d

alexeirivera87 force-pushed the 16.0-mig-maintenance_plan branch from 23e4e60 to 106a09d Compare February 1, 2024 18:01

etobella approved these changes Feb 1, 2024

View reviewed changes

victoralmau approved these changes Feb 2, 2024

View reviewed changes

OCA-git-bot added the approved label Feb 2, 2024

OCA-git-bot added the bot is merging ⏳ label Feb 2, 2024

OCA-git-bot merged commit 85bba0e into OCA:16.0 Feb 2, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 2, 2024

OCA-git-bot added this to the 16.0 milestone Mar 11, 2024

OCA-git-bot mentioned this pull request Mar 11, 2024

Migration to version 16.0 #240

Open

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] maintenance_plan #339

[16.0] [MIG] maintenance_plan #339

alexeirivera87 commented Jun 14, 2023

etobella Jun 14, 2023

aleuffre left a comment

aleuffre Jun 17, 2023 •

edited

Loading

aleuffre commented Jun 17, 2023

mamcode commented Jul 1, 2023 •

edited

Loading

mcassuto commented Jul 5, 2023

aleuffre commented Jul 5, 2023

mcassuto commented Jul 5, 2023

alexeirivera87 commented Jul 5, 2023

aleuffre commented Jul 5, 2023 •

edited

Loading

etobella commented Jul 6, 2023

aleuffre commented Jul 12, 2023

etobella commented Sep 6, 2023

alexeirivera87 commented Jan 30, 2024

etobella commented Jan 30, 2024

alexeirivera87 commented Feb 1, 2024

etobella commented Feb 1, 2024

victoralmau commented Feb 1, 2024

alexeirivera87 commented Feb 1, 2024

victoralmau left a comment

etobella commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

etobella commented Mar 11, 2024

OCA-git-bot commented Mar 11, 2024

etobella commented Mar 11, 2024

[16.0] [MIG] maintenance_plan #339

[16.0] [MIG] maintenance_plan #339

Conversation

alexeirivera87 commented Jun 14, 2023

etobella Jun 14, 2023

Choose a reason for hiding this comment

aleuffre left a comment

Choose a reason for hiding this comment

aleuffre Jun 17, 2023 • edited Loading

Choose a reason for hiding this comment

aleuffre commented Jun 17, 2023

mamcode commented Jul 1, 2023 • edited Loading

mcassuto commented Jul 5, 2023

aleuffre commented Jul 5, 2023

mcassuto commented Jul 5, 2023

alexeirivera87 commented Jul 5, 2023

aleuffre commented Jul 5, 2023 • edited Loading

etobella commented Jul 6, 2023

aleuffre commented Jul 12, 2023

etobella commented Sep 6, 2023

alexeirivera87 commented Jan 30, 2024

etobella commented Jan 30, 2024

alexeirivera87 commented Feb 1, 2024

etobella commented Feb 1, 2024

victoralmau commented Feb 1, 2024

alexeirivera87 commented Feb 1, 2024

victoralmau left a comment

Choose a reason for hiding this comment

etobella commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

OCA-git-bot commented Feb 2, 2024

etobella commented Mar 11, 2024

OCA-git-bot commented Mar 11, 2024

etobella commented Mar 11, 2024

aleuffre Jun 17, 2023 •

edited

Loading

mamcode commented Jul 1, 2023 •

edited

Loading

aleuffre commented Jul 5, 2023 •

edited

Loading