-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][IMP] fieldservice_crm: Added button to create FSM orders directly from leads #1333
Conversation
Hi @patrickrwilson, |
7efae96
to
c87617f
Compare
c87617f
to
f9055a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat and code review
Hi @brian10048, this issue happens when the module fieldservice_account_analytic is installed. It seems to be caused by an onchange on the contact field that sets the location. The thing is that this module doesn't depend on fieldservice_account_analytic, so I can't directly modify this behavior. A possible solution would be to add a dependency on this module and apply some changes to make it work, but I'm not sure if the module author would agree with this approach. If you try it without the fieldservice_account_analytic it will populate. Let me know what you think! |
@BernatObrador Ok, I was confused since the code in your PR looked correct. I can port #1322 to 17.0 and that should solve it |
@brian10048 Ok! I think with the port has to work properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 10abb77. Thanks a lot for contributing to OCA. ❤️ |
This implementation adds the possibility to create FSM orders directly from the CRM form through a wizard.
It simplifies the creation of FSM orders from leads, and it will automatically create the customer's FSM location if it does not already exist.
cc https://github.com/APSL 3932
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review