Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] fieldservice_crm: Added button to create FSM orders directly from leads #1333

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

BernatObrador
Copy link

@BernatObrador BernatObrador commented Mar 5, 2025

This implementation adds the possibility to create FSM orders directly from the CRM form through a wizard.
It simplifies the creation of FSM orders from leads, and it will automatically create the customer's FSM location if it does not already exist.

cc https://github.com/APSL 3932

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

@OCA-git-bot
Copy link
Contributor

Hi @patrickrwilson,
some modules you are maintaining are being modified, check this out!

@BernatObrador BernatObrador force-pushed the 17.0-imp-fieldservice_crm branch from 7efae96 to c87617f Compare March 5, 2025 09:36
@BernatObrador BernatObrador force-pushed the 17.0-imp-fieldservice_crm branch from c87617f to f9055a3 Compare March 5, 2025 09:44
@max3903 max3903 added this to the 17.0 milestone Mar 5, 2025
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

@brian10048
Copy link
Contributor

I was expecting the FSM Location to be set on the new FSM Order, but it is not populated?

image

@BernatObrador
Copy link
Author

BernatObrador commented Mar 5, 2025

Hi @brian10048, this issue happens when the module fieldservice_account_analytic is installed.

It seems to be caused by an onchange on the contact field that sets the location.

The thing is that this module doesn't depend on fieldservice_account_analytic, so I can't directly modify this behavior.

A possible solution would be to add a dependency on this module and apply some changes to make it work, but I'm not sure if the module author would agree with this approach.

If you try it without the fieldservice_account_analytic it will populate.

Let me know what you think!

@brian10048
Copy link
Contributor

@BernatObrador Ok, I was confused since the code in your PR looked correct. I can port #1322 to 17.0 and that should solve it

@BernatObrador
Copy link
Author

BernatObrador commented Mar 5, 2025

@brian10048 Ok! I think with the port has to work properly.

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@brian10048 brian10048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1333-by-brian10048-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a85a54c into OCA:17.0 Mar 11, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 10abb77. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants