-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX]fieldservice_stage_validation: allow fieldservice manager to change fields #1327
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @max3903, @brian10048, |
question: @max3903 @brian10048 if this PR looks fine to you we should also create a new bridge module between Are you ok with this solution? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
Steps to reproduce:
- Login as Mitchell Admin
- Grant Marc Demo the "Field service: user" access right
- Fieldservice -> Configuration -> Stages -> Order -> Confirmed: Add "Actual duration" to "Fields to validate"
- Login as Marc Demo
- Fieldservice: Drag the "Demo Order" from "New" to "Confirmed"
Access Error
You are not allowed to access 'Fields' (ir.model.fields) records.
This operation is allowed for the following groups:
- Administration/Access Rights
- Field Service/Manager
Contact your administrator to request access if necessary.
727036d
to
d907fc7
Compare
I tested this exact workflow and it works with the latest changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review, LGTM
I also added the new bridge module with an additional commit |
24bf126
to
3812a54
Compare
…service_stage_validation and fieldservice_route
3812a54
to
651537e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was too quick to approve, apologies
In
14.0
a user in the groupfieldservice.manager
could change the "Field to Validate" in Field Service > Configuration > Stages.In
16.0
this is not the case anymore, because the group is missing the read permissions onir.model
andir.model.fields
In this PR we restore read permissions while setting some rules to limit them to the relevant tables only.