[17.0][FIX] fieldservice-geoengine: Fix geoengine view filter #1325
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpascuall
approved these changes
Feb 21, 2025
|
This PR has the |
peluko00
approved these changes
Feb 27, 2025
BernatObrador
force-pushed
the
17.0-fix-fieldservice-geoengine
branch
from
f91b668 to
0ddbc08
Compare
The filter of geoengine view of orders was throwing an error because 'display_name' was not found in the items, and was not showing the orders. This happened because the 'display_name' field was not included in the view.
BernatObrador
force-pushed
the
17.0-fix-fieldservice-geoengine
branch
from
eff70aa to
445a3c6
Compare
|
@max3903 is this ready to merge? |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 627821b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter of geoengine view of orders was throwing an error because 'display_name' was not found in the items, and was not showing the orders. This happened because the 'display_name' field was not included in the view.
Errors:
Not showing current orders:
Error when trying to filter:
cc https://github.com/APSL 167441
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review