Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] fieldservice_geoengine: Remove widget for shape field #1324

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[16.0][FIX] fieldservice_geoengine: Remove widget for shape field #1324

merged 1 commit into from
Mar 6, 2025

Conversation

anusriNPS
Copy link

Widget "geo_edit_map" is not required as field type "GeoPoint" is used to identify the same. So, widget is removed for "shape" field.

@anusriNPS
[16.0][FIX] fieldservice_geoengine: Remove widget for shape field
e168ea7 
   Widget "geo_edit_map" is not required as field type "GeoPoint"
is used to identify the same. So, widget is removed for "shape"
field.
@OCA-git-bot
Copy link
Contributor

Hi @max3903, @wolfhall,
some modules you are maintaining are being modified, check this out!

aleuffre
aleuffre approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map is not shown without this change (and a warning is logged in console instead)

Code and functional review, LGTM

@max3903 max3903 added this to the 16.0 milestone Mar 5, 2025
BernatObrador
BernatObrador approved these changes Mar 5, 2025
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review + tested in runboat.
Could be great if you port this to 17 too!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@brian10048
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1324-by-brian10048-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9f3c77d into OCA:16.0 Mar 6, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2d057ae. Thanks a lot for contributing to OCA. ❤️

anusriNPS added a commit to PyTech-SRL/field-service that referenced this pull request Mar 6, 2025
@anusriNPS
[17.0][FIX] fieldservice_geoengine: Remove widget for shape field
92e3e52 
    Porting of PR OCA#1324

    Widget "geo_edit_map" is not required as field type "GeoPoint"
is used to identify the same. So, widget is removed from "shape"
field.
@anusriNPS anusriNPS mentioned this pull request Mar 6, 2025
Open
@aleuffre aleuffre deleted the 16.0-show-map branch March 7, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@aleuffre aleuffre aleuffre approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@anusriNPS @OCA-git-bot @brian10048 @marcelsavegnago @aleuffre @BernatObrador @max3903