Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] fieldservice_recurring: company required on recurring #1167

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

aleuffre
Copy link
Contributor

@aleuffre aleuffre commented Apr 3, 2024

Company is required, to match FS Order. Order generation fails if company is not set

Company is required, to match FS Order. Order generation fails
if company is not set
@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @max3903, @brian10048,
some modules you are maintaining are being modified, check this out!

@max3903 max3903 added this to the 14.0 milestone Apr 3, 2024
@max3903 max3903 self-assigned this Apr 3, 2024
@max3903 max3903 requested review from hparfr and brian10048 April 3, 2024 14:07
Copy link
Contributor

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@max3903
Copy link
Member

max3903 commented Apr 3, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1167-by-max3903-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 3, 2024
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1167-by-max3903-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a6fdb97 into OCA:14.0 Apr 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 700177b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants