Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] base_wamas_ubl: rebuild mapping dynamically and override default mapping #917

Closed

Conversation

QuocDuong1306
Copy link

No description provided.

"BOITE": "XBX", # box
"LITRE": "LTR", # litre
"PET": "XBO", # glass bottle
"TETRA": "X4A", # tetra pack, changed 'X4B' to 'X4A'for testing
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi reviewer, the default of 'TETRA' is X4B, so i just want to change to X4A to test

To make sure that it override the default no

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-imp-base_wamas_ubl branch from 73fc122 to ff69deb Compare February 1, 2024 14:38
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-imp-base_wamas_ubl branch 2 times, most recently from 245fb8b to eb38fc6 Compare February 2, 2024 08:55
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 🙈 🙈
I definitely dislike this kind of implementation, sorry.
Not a blocker tho as this module's utils should be refactored anyway.

@jbaudoux
Copy link
Contributor

I dropped all the unitcode mapping in 46b79ba

@simahawk This PR can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants