-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] base_wamas_ubl: rebuild mapping dynamically and override default mapping #917
Conversation
"BOITE": "XBX", # box | ||
"LITRE": "LTR", # litre | ||
"PET": "XBO", # glass bottle | ||
"TETRA": "X4A", # tetra pack, changed 'X4B' to 'X4A'for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi reviewer, the default of 'TETRA' is X4B, so i just want to change to X4A to test
To make sure that it override the default no
73fc122
to
ff69deb
Compare
245fb8b
to
eb38fc6
Compare
eb38fc6
to
d25f5b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 🙈 🙈
I definitely dislike this kind of implementation, sorry.
Not a blocker tho as this module's utils should be refactored anyway.
No description provided.