Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPD] base_wamas_ubl: Update grammars ART, ARTEAN, WEAK, WEAP, related tests and fix utils #916

Merged
merged 3 commits into from
Feb 1, 2024
Merged

[UPD] base_wamas_ubl: Update grammars ART, ARTEAN, WEAK, WEAP, related tests and fix utils #916

merged 3 commits into from
Feb 1, 2024

Conversation

tuantrantg
Copy link
Contributor

@tuantrantg tuantrantg commented Jan 31, 2024 •
edited
Loading

  • Edit ART grammar and fix parsing boolean value to string
  • Update grammars of ARTEAN, WEAK, WEAP and related tests

@tuantrantg tuantrantg marked this pull request as ready for review January 31, 2024 03:36
@tuantrantg tuantrantg changed the title [UPD] base_wamas_ubl: Edit ART grammar and fix parsing boolean value to string [UPD] base_wamas_ubl: Update grammars ART, ARTEAN, WEAK, WEAP, related tests and fix utils Jan 31, 2024
@simahawk
Copy link
Contributor

@tuantrantg as per #913 pls, try to keep commit msg clear

@tuantrantg tuantrantg force-pushed the 16.0-base_wamas_ubl-ref_code_art branch from b5f289b to 01de8a1 Compare January 31, 2024 10:02
@tuantrantg
Copy link
Contributor Author

@tuantrantg as per #913 pls, try to keep commit msg clear

Hi @simahawk please review it again, thank you

@simahawk
Copy link
Contributor

to be rebased

@tuantrantg tuantrantg force-pushed the 16.0-base_wamas_ubl-ref_code_art branch from 01de8a1 to 9355414 Compare February 1, 2024 03:05
@tuantrantg
Copy link
Contributor Author

to be rebased

hi @simahawk it's rebased

@simahawk
Copy link
Contributor

simahawk commented Feb 1, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-916-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 935e295 into OCA:16.0 Feb 1, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 42a2730. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuantrantg @simahawk @OCA-git-bot