Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] edi_product_import #882

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

florentx
Copy link

@florentx florentx commented Dec 1, 2023

New glue add-on for product_import

(initial PR #760)

@simahawk
Copy link
Contributor

simahawk commented Dec 1, 2023

I'd say this module should go to https://github.com/OCA/edi-framework and be based on OCA/edi-framework#43 (to be backported to 14.0) so that you can also see exchanges linked to the product.

Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with that, though I don't know about @simahawk comment

Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bofiltd
Copy link

bofiltd commented May 16, 2024

Any update on this?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@bosd
Copy link
Contributor

bosd commented Sep 25, 2024

Ok with that, though I don't know about @simahawk comment

@simahawk Can you elaborate?
Should we merge it in this repo?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment remains valid

@florentx
Copy link
Author

For Odoo 14, it would add some burden to depend on edi_product_oca because:

  • add-on edi_oca is still in OCA/edi repositiory and it will probably stay there (14.0 is old/stable enough)
  • add-on edi_product_oca does not exist for 14.0, neither in OCA/edi-framework and neither in OCA/edi
  • even if porting edi_product_oca to 14.0 seems doable, it seems it will just make the dependencies more complicated for not much benefits

@simahawk
Copy link
Contributor

Fair enough. I definitely see benefits in depending on it, in general... Yet, as for 14 let's go this way and simply add a TODO for migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants