Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] base_wamas_ubl group wamas lines #1128

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Feb 17, 2025

With this improvement wamas rows can be aggregated (sum) by a key.
Values belonging to the same group of rows are added together.

For example this sample wamas file:

WAMAS     ODOO      00000120230501065723WEAKQ0051000196241              HOST 20230501060217                                                  19700101010000202305010609112023050106433920230501060221                                                                             0001040         
WAMAS     ODOO      00000220230501065723WEAPQ0050000196241              000130377              HOST                     00002045415               0001151                00000DISPONIBLE          000001536000000000010000     BOUT                     19700101                    12    eCAM  018090  N
WAMAS     ODOO      00000320230501065723WEAPQ0050000196241              000130377              HOST                     00002045415               0001151                00000DISPONIBLE          000001536000000000010000     BOUT                     19700101                    12    eCAM  018090  N
WAMAS     ODOO      00000420230501065723WEAPQ0050000196241              000130377              HOST                     00004045415               0001160                00000DISPONIBLE          000003840000000000000000     BOUT                     19700101                    12    eCAM  018090  N

Is equivalent to this one where line product quantity and weight are merged by summing them.

WAMAS     ODOO      00000120230501065723WEAKQ0051000196241              HOST 20230501060217                                                  19700101010000202305010609112023050106433920230501060221                                                                             0001040         
WAMAS     ODOO      00000220230501065723WEAPQ0050000196241              000130377              HOST                     00002045415               0001151                00000DISPONIBLE          000003072000000000020000     BOUT                     19700101                    12    eCAM  018090  N
WAMAS     ODOO      00000420230501065723WEAPQ0050000196241              000130377              HOST                     00004045415               0001160                00000DISPONIBLE          000003840000000000000000     BOUT                     19700101                    12    eCAM  018090  N

2 lines sum

image

Copy link
Contributor

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never saw a line split into 2 lines by wamas.
You need unique identifier (ExtRef) on each line you send to wamas to be able to map back the response to the right move;

@santostelmo
Copy link
Contributor Author

I never saw a line split into 2 lines by wamas. You need unique identifier (ExtRef) on each line you send to wamas to be able to map back the response to the right move;

I'll need the real usecase and the expected UBL result. Olivier gave me a usecase where reception for the same product is done in 2 lines by wamas but maybe I missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants