Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] base_wamas_ubl sub-transfer #1125

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[16.0][IMP] base_wamas_ubl sub-transfer #1125

merged 1 commit into from
Feb 11, 2025

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Feb 7, 2025 •
edited
Loading

Possibility of defining a transfer sub-level that is interpreted at line level.

EXAMPLE:

WAMAS     ODOO      00000720250114132733WEAKQ0051000212712              ODOO 20250114070918                                                  19700101010000202501140710472025011413132320250114070939                                                                             0001069         
WAMAS     ODOO      00000820250114132733WEAPQ0050000212712              000ABCDE/IN/00424      ODOO 000185              0000019623                00099098 2             00000DISPONIBLE          000000100000000000000000     BOUT                     19700101                    12    eCAM  173980  N
WAMAS     ODOO      00000920250114132733WEAPQ0050000212712              000ABCDE/IN/00409      ODOO 000176              0000019623                00012766               00000DISPONIBLE          000000114000000000000000     BOUT                     19700101                    12    eCAM  173970  N
WAMAS     ODOO      00001020250114132733WEAPQ0050000212712              000ABCDE/IN/00409      ODOO 000176              0000019623                00012766               00000DISPONIBLE          000000115000000000000000     BOUT                     19700101                    12    eCAM  173970  N

In this example we will have as a result 2 transfers where the key is composed by:
212712 + ABCDE/IN/00424
212712 + ABCDE/IN/00409

@santostelmo santostelmo marked this pull request as draft February 7, 2025 11:27
jbaudoux
jbaudoux reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG so far.

What happens afterwards? How is parsed the transfers dict? Are items without lines dropped?

@santostelmo santostelmo force-pushed the 16.0-imp-base_wamas_ubl-sub-transfer branch from 37fd0dc to b1f7b1f Compare February 10, 2025 06:17
@santostelmo
Copy link
Contributor Author

@jbaudoux I updated the code with your changes and added unit test

@santostelmo santostelmo marked this pull request as ready for review February 10, 2025 06:20
@santostelmo
Copy link
Contributor Author

LG so far.

What happens afterwards? How is parsed the transfers dict? Are items without lines dropped?

transfers dict is built while reading each line. At the end of reading all the lines, transfers is copied to self.transfers

@santostelmo santostelmo changed the title [IMP] base_wamas_ubl sub-transfer [16.0][IMP] base_wamas_ubl sub-transfer Feb 10, 2025
cyrilmanuel
cyrilmanuel approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jbaudoux
jbaudoux reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove auto generated files from your commit. It should be there only for new modules.
You can use export SKIP=oca-gen-addon-readme

jbaudoux
jbaudoux reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides minor remarks, it looks good

@santostelmo santostelmo force-pushed the 16.0-imp-base_wamas_ubl-sub-transfer branch from b1f7b1f to 6e6e1fa Compare February 11, 2025 12:46
@santostelmo
Copy link
Contributor Author

Besides minor remarks, it looks good

Update code for the minor remarks

@jbaudoux
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1125-by-jbaudoux-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7136e69 into OCA:16.0 Feb 11, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 22693bc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@santostelmo @jbaudoux @OCA-git-bot @cyrilmanuel