Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] base_ebill_payment_contract #1038

Merged
merged 24 commits into from
Jan 28, 2025

Conversation

TDu
Copy link
Member

@TDu TDu commented Sep 12, 2024

No description provided.

@simahawk
Copy link
Contributor

/ocabot migration base_ebill_payment_contract
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 15, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1038-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 15, 2024
Signed-off-by simahawk
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 15, 2024
17 tasks
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1038-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@TDu TDu force-pushed the 17.0-mig-base_ebill_payment_contract branch from 369c84e to 71f3b0f Compare November 29, 2024 08:10
TDu and others added 17 commits January 16, 2025 10:26
The goal of this module is to be a common ground for ebilling addons.
Alone this module has no purpose. It needs to be installed with a module
that implements a specific ebilling system.
This depending module has to implement his own 'transmit.method'.
Add the search implementation for the is_valid non stored computed
fields. So it works as expected.
Improve how an active contract is found for a partner. It allows to had
some specific filtering for specific services.
Currently translated at 100.0% (20 of 20 strings)

Translation: edi-14.0/edi-14.0-base_ebill_payment_contract
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-base_ebill_payment_contract/es/
@vvrossem vvrossem force-pushed the 17.0-mig-base_ebill_payment_contract branch from 71f3b0f to c7c6520 Compare January 16, 2025 09:26
@vvrossem
Copy link
Contributor

Hello dear @simahawk 👋
I've just rebased this PR, tests are green again: do you think you can try rerunning your previous commands?

/ocabot migration base_ebill_payment_contract
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ecino
Copy link

ecino commented Jan 20, 2025

I think we can merge now 👍

@ecino
Copy link

ecino commented Jan 28, 2025

@simahawk This one also can be merged if you agree :)

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1038-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4878151. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit c9fed9e into OCA:17.0 Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants