Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] delivery_correos_express: Migration to 17.0 #906

Open
wants to merge 9 commits into
base: 17.0
Choose a base branch
from

Conversation

pablo-cort-s73
Copy link

@pablo-cort-s73 pablo-cort-s73 commented Nov 22, 2024

Depends on:

@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from 9f1c376 to 2b42409 Compare November 22, 2024 09:04
@pedrobaeza pedrobaeza changed the title [17.0][MIG] delivery correos express: Migration to 17.0 [17.0][MIG] delivery_correos_express: Migration to 17.0 Nov 22, 2024
@pedrobaeza
Copy link
Member

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch 4 times, most recently from 27143df to 9378e94 Compare November 29, 2024 11:55
@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from 9378e94 to 9c7b656 Compare December 12, 2024 13:01
@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from 9c7b656 to 70e2c17 Compare January 16, 2025 15:17
@pedrobaeza
Copy link
Member

Take into account this fix done in 15.0 migration: 19b2722#diff-fc0ee4a55021761bea7e0737694662bf7ab7b58450fa901711ec03027a5062d0R44

@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch 5 times, most recently from db5057a to ace1707 Compare January 30, 2025 12:48
Copy link

@juancarlosonate-tecnativa juancarlosonate-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the SSL issues in test mode? Maybe we could change the test-to-prod and debug buttons to booleans so they are easier to understand.

('delivery_type', '!=', 'correos_express'),
('state', '!=', 'done')
]}"
invisible="(carrier_tracking_ref != True) or (delivery_type != 'correos_express') or (state != 'done')"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the button is not displaying correctly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the button to print the label still not appearing, look 16:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En este repositorio se puede hablar en español para facilitar la colaboración.

Copy link
Author

@pablo-cort-s73 pablo-cort-s73 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solucionado, era al realizar la comprobación:
delivery_carrier_ref != True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

al intentar imprimir, hay algo que estoy pasando por alto?
image

Copy link
Author

@pablo-cort-s73 pablo-cort-s73 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pues seguramente varias cosas, hay que tener un número de seguimiento válido, y para eso hace falta un usuario, contraseña, codigo de cliente... que crea el envío y con ese número de seguimiento ya puedes hacer la petición, que en realidad descarga la etiqueta en .pdf y se adjunta al picking.
El entorno de pruebas no funciona, así que solamente se puede probar en producción, yo lo he hecho y funciona correctamente.
Puedes intentarlo con un número de seguimiento real.

"dato": picking.carrier_tracking_ref,
}

def correos_express_tracking_state_update(self, picking):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this working?

Copy link
Author

@pablo-cort-s73 pablo-cort-s73 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juancarlosonate-tecnativa te refieres a la función def correos_express_tracking_state_update(self, picking)?

@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from ace1707 to 7169ca2 Compare February 25, 2025 13:58
@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from 7169ca2 to 8a73c56 Compare February 25, 2025 14:36
@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from 8a73c56 to d18b821 Compare March 5, 2025 09:57
@pablo-cort-s73 pablo-cort-s73 force-pushed the 17.0-mig-delivery_correos_express branch from d18b821 to 3a837dd Compare March 5, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants