Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16][ADD] delivery_roulier_geodis_fr #899

Merged
merged 13 commits into from
Mar 13, 2025
Merged

[16][ADD] delivery_roulier_geodis_fr #899

merged 13 commits into from
Mar 13, 2025

Conversation

florian-dacosta
Copy link
Contributor

Add carrier label implementation for geodis (calberson/france express) carrier in v16

@florian-dacosta florian-dacosta force-pushed the 16.0-mig-delivery_roulier_geodis_fr branch from f70b116 to 6ccda3f Compare October 30, 2024 16:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 2, 2025
@florian-dacosta
Copy link
Contributor Author

@bguillot @hparfr Would you mind to do a code review ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 9, 2025
hparfr
hparfr approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-899-by-hparfr-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 12, 2025
@OCA-git-bot
Merge PR #899 into 16.0
96d620b 
Signed-off-by hparfr
@OCA-git-bot
Copy link
Contributor

@hparfr your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-899-by-hparfr-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@florian-dacosta
Precommit and rename delivery_roulier_geodis on delivery_roulier_geod…
4d54c0b 
…is_fr
@florian-dacosta
Migrate delivery_roulier_geodis_fr
9ebb1c1
@florian-dacosta
Fix notification for geodis M means mail AND sms while P means email
b28e429
@florian-dacosta
[FIX] Make sure tracking account is not choosen for labels
1ad6ca4
@florian-dacosta
[IMP] delivery_roulier_geodis_fr: black, isort, prettier
efdc6e2
@florian-dacosta
[MIG][16] Migrate delivery_roulier_geodis_fr to v16
cb7e7eb
@florian-dacosta
[IMP] delivery_roulier_geodis_fr : Update tracking ref on picking
05114ec
@florian-dacosta
[FIX] delivery_roulier_geodis_fr : Fix notification when no email and…
9bc4aa4 
… phone
@florian-dacosta
[FIX] delivery_roulier_geodis_fr : change dependency of renamed module
1262db1
@florian-dacosta
[FIX] Do not copy geodis_shippingid as we dont want to send the same …
1a214c3 
…to geodis in case of return and new shipping
@florian-dacosta
[IMP] add hook to get package vals for EDI
0d884a6
@florian-dacosta
[IMP] delivery_roulier_geodis_fr : fix tests + add maintainer
f17416d
@florian-dacosta florian-dacosta force-pushed the 16.0-mig-delivery_roulier_geodis_fr branch from 6ccda3f to f17416d Compare March 12, 2025 12:48
hparfr
hparfr reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-899-by-hparfr-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 347401c. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 41ba48d into OCA:16.0 Mar 13, 2025
7 checks passed
@hparfr hparfr deleted the 16.0-mig-delivery_roulier_geodis_fr branch March 13, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@bguillot bguillot bguillot approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florian-dacosta @OCA-git-bot @bguillot @hparfr