Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base_delivery_carrier_label test decorators #862

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

gurneyalex
Copy link
Member

Previous fix was incomplete: the class method should only call other class methods

@gurneyalex gurneyalex requested a review from yankinmax July 17, 2024 08:36
Previous fix was incomplete: the class method should only call other
class methods
@gurneyalex gurneyalex force-pushed the 17.0-fix_testcase_helper2 branch from 8d651aa to 5b9cd5a Compare July 18, 2024 10:24
@yankinmax
Copy link
Contributor

@gurneyalex
I've used your fix and tried to rewrite tests for delivery_roulier_chronopost_fr
As I've written here #830 (comment)
finally I think we shouldn't inherit from this test.

@gurneyalex
Copy link
Member Author

@gurneyalex I've used your fix and tried to rewrite tests for delivery_roulier_chronopost_fr As I've written here #830 (comment) finally I think we shouldn't inherit from this test.

I will still get this merged, to have some correct code in the module.

@gurneyalex
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-862-by-gurneyalex-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 16502db into OCA:17.0 Jul 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba07484. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants