Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delivery_roulier: fix call to dead code #820

Merged
merged 1 commit into from
Jul 9, 2024
Merged

delivery_roulier: fix call to dead code #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions delivery_roulier/models/delivery_carrier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
# Maybe we will merge all this in future versions
def get_tracking_link(self, picking):
if self._is_roulier():
packages = picking._get_packages_from_picking()
packages = picking.package_ids

Check warning on line 42 in delivery_roulier/models/delivery_carrier.py

View check run for this annotation

Codecov / codecov/patch

delivery_roulier/models/delivery_carrier.py#L42 

Added line #L42 was not covered by tests
first_package = packages and packages[0]
if first_package:
return first_package._get_tracking_link(picking)
return first_package._get_tracking_link()

Check warning on line 45 in delivery_roulier/models/delivery_carrier.py

View check run for this annotation

Codecov / codecov/patch

delivery_roulier/models/delivery_carrier.py#L45 

Added line #L45 was not covered by tests
else:
return super().get_tracking_link(picking)
Loading