Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] [MIG] delivery_package_fee: Migration to 15.0 #804

Closed

Conversation

bizzappdev
Copy link

No description provided.

guewen and others added 19 commits April 30, 2024 12:02
A list of Package Fees can be added on shipping methods.
When a outgoing transfer is done, for each package fee configured on the
shipping method, a new sale order line is created with:

* The product selected on the Package Fee
* The product name with the number of the transfer in the line's description
  (e.g. "Service Fee (WH/OUT/00036)")
* The quantity equal to the number of packages in the transfer
* The unit price equal to the price set on the product's pricelist (so it can be
  different per customer and even have different pricing depending on the number
  of packages)
* The taxes configured on the product, fiscal position applies if any.

Package Fee lines are added only if their quantity and price is above zero.
Flag package fee order lines with a new boolean 'is_delivery_package_fee'.
Standard method '_is_delivery' will also consider this field to exclude
the lines from the computation of the 'expected_date' in 'sale' module.
'order_line' can be empty when SO is copied
from direct call to copy with False as default.
Currently translated at 100.0% (18 of 18 strings)

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_package_fee
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_package_fee/es/
@rousseldenis
Copy link
Contributor

/ocabot migration delivery_package_fee

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Minor comment

@bizzappdev bizzappdev force-pushed the 15.0-mig-delivery_package_fee-BAD branch from 825e43c to 8ff7fe6 Compare April 30, 2024 07:05
@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 30, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 30, 2024
32 tasks
@bizzappdev bizzappdev force-pushed the 15.0-mig-delivery_package_fee-BAD branch from 2c287a7 to 8ff7fe6 Compare May 2, 2024 06:29
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@github-actions github-actions bot closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.