Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] delivery_deliverea: Generate a deliverea return when sending to shipper #803

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

bencoronel
Copy link
Contributor

Changed send_to_shipper method to generate the return.

The Print Label button was generating the return instead of the Generate Return button and the Label wasn't being saved.

Now the Generate Return actually generates the return.

@bencoronel bencoronel force-pushed the 16.0-fix-delivery-deliverea branch 2 times, most recently from 3662761 to e1e8b87 Compare May 27, 2024 10:16
@bencoronel bencoronel force-pushed the 16.0-fix-delivery-deliverea branch from e1e8b87 to 401e673 Compare May 27, 2024 10:55
Copy link
Contributor

@OscarIndias OscarIndias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 29, 2024
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-803-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e8550c8 into OCA:16.0 Sep 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c95f200. Thanks a lot for contributing to OCA. ❤️

@zahravelasco zahravelasco deleted the 16.0-fix-delivery-deliverea branch October 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants