Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] base_delivery_carrier_label: fix weight computation logic #802

Closed
wants to merge 1 commit into from
Closed

[14.0][FIX] base_delivery_carrier_label: fix weight computation logic #802

wants to merge 1 commit into from

Conversation

alexis-via
Copy link
Contributor

Re-write tests for get_weight()

@alexis-via alexis-via force-pushed the 14-fix-base_delivery_carrier_label-weight_computation branch from bef3d72 to f1b2be8 Compare May 6, 2024 14:56
@rousseldenis
Copy link
Contributor

rousseldenis commented May 6, 2024 •
edited
Loading

@alexis-via FYI tests are stuck. Issue opened : #806

@alexis-via alexis-via force-pushed the 14-fix-base_delivery_carrier_label-weight_computation branch from f1b2be8 to 6e784c3 Compare June 3, 2024 14:35
@alexis-via alexis-via force-pushed the 14-fix-base_delivery_carrier_label-weight_computation branch from 6e784c3 to c28133d Compare June 3, 2024 14:38
@alexis-via
Copy link
Contributor Author

@rousseldenis Rebased. It's all green now

rousseldenis
rousseldenis approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@alexis-via
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Sorry @alexis-via you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@alexis-via
Copy link
Contributor Author

Can someone merge this ?

@rousseldenis
Copy link
Contributor

/ocabot merge minor

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
@github-actions github-actions bot closed this Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexis-via @rousseldenis @OCA-git-bot @legalsylvain