Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] delivery_carrier_info #779

Merged
merged 23 commits into from
May 2, 2024

Conversation

AndreuOForgeFlow
Copy link

Standard Migration

@ForgeFlow

sebastienbeau and others added 22 commits March 7, 2024 13:54
Currently translated at 42.8% (3 of 7 strings)

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_info
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_info/fr/
Currently translated at 100.0% (3 of 3 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_carrier_info
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_carrier_info/es/
@AndreuOForgeFlow AndreuOForgeFlow force-pushed the 17.0-mig-delivery_carrier_info branch from c0aa851 to f257c9f Compare March 7, 2024 15:21
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code and functional review 👍🏽

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_info

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 12, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 12, 2024
34 tasks
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

I know this has been discussed but I'm wondering if this deserves a base module to add a group in forms and then add 'code' and so on...

@florian-dacosta

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-779-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 038c27b into OCA:17.0 May 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0a79fc7. Thanks a lot for contributing to OCA. ❤️

@AndreuOForgeFlow AndreuOForgeFlow deleted the 17.0-mig-delivery_carrier_info branch May 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.