Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [MIG-IMP] delivery_ups_oca, migration and oauth #776

Merged
merged 32 commits into from
May 27, 2024
Merged

[14.0] [MIG-IMP] delivery_ups_oca, migration and oauth #776

merged 32 commits into from
May 27, 2024

Conversation

manuelregidor
Copy link

@manuelregidor manuelregidor commented Feb 29, 2024 •
edited
Loading

Working features:

  • Token creation/renew
  • Shipping rating
  • New shipping
  • Automatic label when a shipping is created
  • Label recreation
  • URL to UPS tracking website
  • Shipping cancel
  • Tracking (although it has not been fully developed in the new API by UPS yet)
  • Cash on delivery

hbrunn and others added 30 commits February 29, 2024 15:14
@hbrunn @manuelregidor
[ADD] delivery_carrier_label_ups
c9b7a9a
@StefanRijnhart @manuelregidor
[RFR] Extract Test classes from Case classes for easier overriding
d9a49ed
@astirpe @manuelregidor
[FIX] access to ir.config_parameter
c0e36a0
@victoralmau @manuelregidor
[IMP] delivery_carrier_label_ups: black, isort, prettier
7f22d69
@victoralmau @manuelregidor
[MIG] delivery_ups_oca: Migration to 13.0 + Refactor
010cc3f
@oca-travis @manuelregidor
[UPD] Update delivery_ups_oca.pot
f91ed2c
@OCA-git-bot @manuelregidor
[UPD] README.rst
dc939fd
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Prevent error when convert price in different…
a19835d 
… currency.
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.1.0.1
2bcd66a
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Define the total weight correctly in an order.
3fd9a40
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.1.0.2
0f8afc6
@victoralmau @manuelregidor
[REF] delivery_ups_oca: Code refactor.
b4322f3
@oca-travis @manuelregidor
[UPD] Update delivery_ups_oca.pot
0c33cb9
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.1.0.3
41f1c28
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Pevent errors in tests.
63a0dc0
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.1.0.4
0405cc8
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Show the errors to avoid the error of access …
41237f5 
…to a non-existing key in the code.

TT37248
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.1.0.5
cdda19b
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Create label from create_shipping response to…
69ce79e 
… avoid error.

TT37248
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Set the correct URLs.
d6a1906
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Apply domain to ups_default_packaging_id fiel…
7e21077 
…d to show only UPS records.

TT37248
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Set the correct weight if we use packages.
554234d 
TT37180
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Fix packages when package_ids is not set.
daeb623 
TT37248
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Set correct ShipFrom (warehouse or company ad…
5c28412 
…dress).
@victoralmau @manuelregidor
[IMP] delivery_ups_oca: Improve tests to allow inheritance.
cd8788b 
TT37248
@manuelregidor
[UPD] Update delivery_ups_oca.pot
6548d52
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.2.0.0
3145587
@victoralmau @manuelregidor
[FIX] delivery_ups_oca: Fix cancel_shipment method
a47e55e 
TT40776
@OCA-git-bot @manuelregidor
delivery_ups_oca 13.0.2.0.1
e629173
@OCA-git-bot @manuelregidor
[UPD] README.rst
143fdde
@ValentinVinagre
Copy link
Contributor

@pedrobaeza @etobella What do you think about this?

@LoisRForgeFlow @rousseldenis @Cedric-Pigeon The previous version of the UPS connector, which used a different authentication method, had tests that set connection with UPS through credentials borrowed from an enterprise runbot. With oauth, that is not possible anymore, as there are not test credentials available for Odoo Enterprise. Should I use mock methods instead? Thank you.

@pedrobaeza
Copy link
Member

OK, do the mocks.

@manuelregidor manuelregidor force-pushed the 14.0-mig-delivery_ups_oca branch from 7365a67 to 5e732f3 Compare March 22, 2024 11:50
@manuelregidor
Copy link
Author

@LoisRForgeFlow @rousseldenis @Cedric-Pigeon Could you review, please? Thank you.

@rousseldenis
Copy link
Contributor

@LoisRForgeFlow @rousseldenis @Cedric-Pigeon Could you review, please? Thank you.

@manuelregidor Could you change PR's title ?

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_ups_oca

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Mar 28, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 28, 2024
Closed
21 tasks
@manuelregidor manuelregidor changed the title [WIP] [14.0] [MIG-IMP] delivery_ups_oca, migration and oauth [14.0] [MIG-IMP] delivery_ups_oca, migration and oauth Mar 28, 2024
luis-ron
luis-ron approved these changes May 23, 2024
View reviewed changes
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM 👍🏻

@luis-ron
Copy link

@ValentinVinagre @Tisho99 Could you review, please? Thank you.

ValentinVinagre
ValentinVinagre approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 .
@JordiBForgeFlow @JordiMForgeFlow @LoisRForgeFlow
you need finally this module? if yes, could do a review 😄

JordiMForgeFlow
JordiMForgeFlow reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the nitpicking 🙏🏼, for the rest code review LGTM

@manuelregidor manuelregidor force-pushed the 14.0-mig-delivery_ups_oca branch from 5e732f3 to 37aafe1 Compare May 23, 2024 09:54
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HaraldPanten
Copy link

@LoisRForgeFlow @JordiBForgeFlow @etobella from the 1st of June, UPS will need this authentication. Could we move this forward?

@LoisRForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-776-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 76f40f7 into OCA:14.0 May 27, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 24011e1. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 14.0-mig-delivery_ups_oca branch May 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@luis-ron luis-ron luis-ron approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.