-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] delivery_deliverea: fix returnLabel attribute #773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @pedrobaeza, could you check this PR? . I have detected an error and with this change it is solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having the API documentation at hand, it's trustable that this is the expected format.
/ocabot merge patch
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
de488c3
to
aa80af4
Compare
aa80af4
to
ff7e5d8
Compare
Hi @pedrobaeza could you run again the bot, please? The tests odoo and ocb failed, i fixed the problems and run again tests, the problems was in another module. Thank You!! 😉 |
/ocabot merge patch |
On my way to merge this fine PR! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at d19cd50. Thanks a lot for contributing to OCA. ❤️ |
Fixed return label attribute in
_get_service_attributes
method to be able to generate return labels based on the configured carrier.