Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] delivery_deliverea: fix returnLabel attribute #773

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

imoralesc
Copy link
Contributor

Fixed return label attribute in _get_service_attributes method to be able to generate return labels based on the configured carrier.

@imoralesc imoralesc changed the title [16.0][FIX] delivery_deliverea [16.0][FIX] delivery_deliverea: fix returnLabel attribute Feb 23, 2024
Copy link
Contributor

@OscarIndias OscarIndias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imoralesc
Copy link
Contributor Author

Hi @pedrobaeza, could you check this PR? . I have detected an error and with this change it is solved.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 26, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having the API documentation at hand, it's trustable that this is the expected format.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 26, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@imoralesc imoralesc force-pushed the 16.0-fix-delivery_deliverea branch from aa80af4 to ff7e5d8 Compare February 26, 2024 17:48
@imoralesc
Copy link
Contributor Author

Hi @pedrobaeza could you run again the bot, please? The tests odoo and ocb failed, i fixed the problems and run again tests, the problems was in another module.

Thank You!! 😉

image

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 26, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f134923 into OCA:16.0 Feb 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d19cd50. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants